New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong metric type for minio_s3_time_ttfb_seconds_distribution? #17060
Comments
MalKeshar
changed the title
Wrong metric type for request duration?
Wrong metric type for minio_s3_time_ttfb_seconds_distribution?
Apr 21, 2023
8 tasks
This issue was fixed incorrectly, this requires an overhaul in the way we calculate. We had to move back to gaugeMetric for now. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 15 days if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem: it is not possible to use histogram_quantile function on minio_s3_time_ttfb_seconds_distribution
Assumption: minio probably use wrong metric type for request duration.
According prometheus documentation for distribution should be used summary and histogram metrics type
https://prometheus.io/docs/practices/histograms/
According https://github.com/minio/minio/blob/master/cmd/metrics-v2.go
request duration is the only minio distribution metric, which use gauge.
Other distributions use Histogram.
I search for answer in github issues, but didn't find it.
It was previously asked in
#14293
#12540
but there was no answer
By any chance is it possible that it's some kind of mistake? Is there any information for such decision?
Thank you.
The text was updated successfully, but these errors were encountered: