Change last activity metric from nanosec to sec

Author: anjalshireesh

cmd/metrics-v3-cluster-scanner.go

@@ -23,12 +23,12 @@ import (
 )
 
 const (
-	scannerBucketScansFinished     = "bucket_scans_finished"
-	scannerBucketScansStarted      = "bucket_scans_started"
-	scannerDirectoriesScanned      = "directories_scanned"
-	scannerObjectsScanned          = "objects_scanned"
-	scannerVersionsScanned         = "versions_scanned"
-	scannerLastActivityNanoSeconds = "last_activity_nano_seconds"
+	scannerBucketScansFinished = "bucket_scans_finished"
+	scannerBucketScansStarted  = "bucket_scans_started"
+	scannerDirectoriesScanned  = "directories_scanned"
+	scannerObjectsScanned      = "objects_scanned"
+	scannerVersionsScanned     = "versions_scanned"
+	scannerLastActivitySeconds = "last_activity_seconds"
 )
 
 var (
@@ -42,8 +42,8 @@ var (
 		"Total number of unique objects scanned since server start")
 	scannerVersionsScannedMD = NewCounterMD(scannerVersionsScanned,
 		"Total number of object versions scanned since server start")
-	scannerLastActivityNanoSecondsMD = NewGaugeMD(scannerLastActivityNanoSeconds,
-		"Time elapsed (in nano seconds) since last scan activity.")
+	scannerLastActivitySecondsMD = NewGaugeMD(scannerLastActivitySeconds,
+		"Time elapsed (in seconds) since last scan activity.")
 )
 
 // loadClusterScannerMetrics - `MetricsLoaderFn` for cluster webhook
@@ -59,7 +59,7 @@ func loadClusterScannerMetrics(ctx context.Context, m MetricValues, c *metricsCa
 	if err != nil {
 		metricsLogIf(ctx, err)
 	} else {
-		m.Set(scannerLastActivityNanoSeconds, float64(time.Since(dui.LastUpdate)))
+		m.Set(scannerLastActivitySeconds, time.Since(dui.LastUpdate).Seconds())
 	}
 
 	return nil

cmd/metrics-v3.go

@@ -307,7 +307,7 @@ func newMetricGroups(r *prometheus.Registry) *metricsV3Collection {
 			scannerDirectoriesScannedMD,
 			scannerObjectsScannedMD,
 			scannerVersionsScannedMD,
-			scannerLastActivityNanoSecondsMD,
+			scannerLastActivitySecondsMD,
 		},
 		loadClusterScannerMetrics,
 	)

docs/metrics/v3.md

@@ -214,7 +214,7 @@ The standard metrics group for GoCollector is not shown below.
 | `minio_cluster_scanner_bucket_scans_finished`      | `counter` | Total number of bucket scans finished since server start   |        |
 | `minio_cluster_scanner_bucket_scans_started`       | `counter` | Total number of bucket scans started since server start    |        |
 | `minio_cluster_scanner_directories_scanned`        | `counter` | Total number of directories scanned since server start     |        |
-| `minio_cluster_scanner_last_activity_nano_seconds` | `gauge`   | Time elapsed (in nano seconds) since last scan activity    |        |
+| `minio_cluster_scanner_last_activity_seconds`      | `gauge`   | Time elapsed (in seconds) since last scan activity         |        |
 | `minio_cluster_scanner_objects_scanned`            | `counter` | Total number of unique objects scanned since server start  |        |
 | `minio_cluster_scanner_versions_scanned`           | `counter` | Total number of object versions scanned since server start |        |