Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to avoid empty rows after upgrade to 1.35.0 #697

Open
1 task done
PatrickSvenssonSL opened this issue Nov 19, 2024 · 0 comments
Open
1 task done

No way to avoid empty rows after upgrade to 1.35.0 #697

PatrickSvenssonSL opened this issue Nov 19, 2024 · 0 comments

Comments

@PatrickSvenssonSL
Copy link

Excel Type

  • XLSX

MiniExcel Version

1.35.0

Description

In version 1.34.2, Query would not return empty rows.
In version 1.35.0 it will return all empty rows as instances of T.
The example in the readme only states how to handle this for the dynamic Query method, not the typed one.
This introduced a lot of issues for us, as we now get thousands of invalid rows, and no way to filter those out as if T is an object, we can't compare to default(T), as default is null, while these empty rows are instances.
The only way to get around this now is to downgrade to the previous version, or use reflection to check the value of each property and compare to default which is not performant and very error-prone.
I think this issue is related to the bugfix of self-closing tags that now end up as items.

A simple solution to this would be to introduce a configuration option to ignore those empty rows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant