You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In version 1.34.2, Query would not return empty rows.
In version 1.35.0 it will return all empty rows as instances of T.
The example in the readme only states how to handle this for the dynamic Query method, not the typed one.
This introduced a lot of issues for us, as we now get thousands of invalid rows, and no way to filter those out as if T is an object, we can't compare to default(T), as default is null, while these empty rows are instances.
The only way to get around this now is to downgrade to the previous version, or use reflection to check the value of each property and compare to default which is not performant and very error-prone.
I think this issue is related to the bugfix of self-closing tags that now end up as items.
A simple solution to this would be to introduce a configuration option to ignore those empty rows.
The text was updated successfully, but these errors were encountered:
Excel Type
MiniExcel Version
1.35.0
Description
In version 1.34.2, Query would not return empty rows.
In version 1.35.0 it will return all empty rows as instances of T.
The example in the readme only states how to handle this for the dynamic Query method, not the typed one.
This introduced a lot of issues for us, as we now get thousands of invalid rows, and no way to filter those out as if T is an object, we can't compare to default(T), as default is null, while these empty rows are instances.
The only way to get around this now is to downgrade to the previous version, or use reflection to check the value of each property and compare to default which is not performant and very error-prone.
I think this issue is related to the bugfix of self-closing tags that now end up as items.
A simple solution to this would be to introduce a configuration option to ignore those empty rows.
The text was updated successfully, but these errors were encountered: