updated some stuff, but will probably delete most of this

Author: Eric Solender

client_test.go

@@ -75,4 +75,3 @@ func TestClientV4(t *testing.T) {
 		t.FailNow()
 	}
 }
-

encoding/encoder.go

@@ -105,6 +105,9 @@ func Marshal(v interface{}) ([]byte, error) {
 
 // write writes to the writer.  Buffers the writes using chunkSize.
 func (e Encoder) Write(p []byte) (n int, err error) {
+	//log.Trace("in encode write")
+	//log.Trace(fmt.Sprintf("len writing is %v", len(p)))
+	//log.Trace(fmt.Sprintf("%x", p))
 
 	n, err = e.buf.Write(p)
 	if err != nil {
@@ -133,6 +136,9 @@ func (e Encoder) Write(p []byte) (n int, err error) {
 func (e Encoder) flush() error {
 	length := e.buf.Len()
 	if length > 0 {
+		if length == 23 {
+			length = 24
+		}
 		if err := binary.Write(e.w, binary.BigEndian, uint16(length)); err != nil {
 			return errors.Wrap(err, "An error occured writing length bytes during flush")
 		}
@@ -291,7 +297,7 @@ func (e Encoder) encodeInt(val int64) error {
 		return errors.New("Int too long to write: %d", val)
 	}
 	if err != nil {
-		return errors.Wrap(err, "An error occured writing an int to bolt")
+		return errors.Wrap(err, "An error occurred writing an int to bolt")
 	}
 	return err
 }
@@ -316,7 +322,7 @@ func (e Encoder) encodeString(val string) error {
 	length := len(bytes)
 	switch {
 	case length <= 15:
-		if _, err = e.Write([]byte{byte(TinyStringMarker + length)}); err != nil {
+		if _, err = e.Write([]byte{byte(TinyStringMarker | length)}); err != nil {
 			return err
 		}
 		_, err = e.Write(bytes)
@@ -354,7 +360,7 @@ func (e Encoder) encodeSlice(val []interface{}) error {
 	length := len(val)
 	switch {
 	case length <= 15:
-		if _, err := e.Write([]byte{byte(TinySliceMarker + length)}); err != nil {
+		if _, err := e.Write([]byte{byte(TinySliceMarker | length)}); err != nil {
 			return err
 		}
 	case length > 15 && length <= math.MaxUint8:
@@ -396,7 +402,7 @@ func (e Encoder) encodeMap(val map[string]interface{}) error {
 	length := len(val)
 	switch {
 	case length <= 15:
-		if _, err := e.Write([]byte{byte(TinyMapMarker + length)}); err != nil {
+		if _, err := e.Write([]byte{byte(TinyMapMarker | length)}); err != nil {
 			return err
 		}
 	case length > 15 && length <= math.MaxUint8:
@@ -443,7 +449,7 @@ func (e Encoder) encodeStructure(val structures.Structure) error {
 	length := len(fields)
 	switch {
 	case length <= 15:
-		if _, err := e.Write([]byte{byte(TinyStructMarker + length)}); err != nil {
+		if _, err := e.Write([]byte{byte(TinyStructMarker | length)}); err != nil {
 			return err
 		}
 	case length > 15 && length <= math.MaxUint8:

structures/messages/ack_failure.go

@@ -2,6 +2,8 @@ package messages
 
 const (
 	// AckFailureMessageSignature is the signature byte for the ACK_FAILURE message
+	// ACK_FAILURE
+	// binary [0000 1110]
 	AckFailureMessageSignature = 0x0E
 )
 

structures/messages/discard.go

@@ -0,0 +1,26 @@
+package messages
+
+const (
+	// DiscardMessageSignature is the signature byte for the DISCARD message
+	// DISCARD
+	// binary [0010 1111]
+	DiscardMessageSignature = 0x2f
+)
+
+// DiscardMessage Represents an DISCARD_ALL message
+type DiscardMessage struct{}
+
+// NewDiscardMessage Gets a new DiscardMessage struct
+func NewDiscardMessage() DiscardMessage {
+	return DiscardMessage{}
+}
+
+// Signature gets the signature byte for the struct
+func (i DiscardMessage) Signature() int {
+	return DiscardMessageSignature
+}
+
+// AllFields gets the fields to encode for the struct
+func (i DiscardMessage) AllFields() []interface{} {
+	return []interface{}{}
+}

structures/messages/discard_all.go

@@ -2,6 +2,8 @@ package messages
 
 const (
 	// DiscardAllMessageSignature is the signature byte for the DISCARD_ALL message
+	// DISCARD_ALL
+	// binary [0010 1111]
 	DiscardAllMessageSignature = 0x2F
 )
 

structures/messages/doc.go

@@ -1,2 +1,4 @@
 /*Package messages contains structs that represent the messages that get sent using the Bolt protocol*/
+// ref here -- https://github.com/neo4j/neo4j-javascript-driver/blob/4.0/src/internal/request-message.js
+// and here -- https://github.com/neo4j/neo4j-javascript-driver/blob/4.0/src/internal/connection-channel.js
 package messages

structures/messages/failure.go

@@ -0,0 +1,22 @@
+package messages
+
+const (
+	// GoodbyeMessageSignature is the signature byte for the GOODBYE message
+	// GOODBYE
+	// binary [0000 00010]
+	GoodbyeMessageSignature = 0x02
+)
+
+type GoodbyeMessage struct{}
+
+func NewGoodbyeMessage() GoodbyeMessage {
+	return GoodbyeMessage{}
+}
+
+func (g GoodbyeMessage) Signature() int {
+	return GoodbyeMessageSignature
+}
+
+func (g GoodbyeMessage) AllFields() []interface{} {
+	return []interface{}{}
+}

structures/messages/goodbye.go

@@ -0,0 +1,26 @@
+package messages
+
+const (
+	// HelloMessageSignature is the signature byte for the HELLO message
+	// HELLO <metadata>
+	// binary [0000 0001]
+	HelloMessageSignature = 0x01
+)
+
+type HelloMessage struct {
+	metadata map[string]interface{}
+}
+
+func NewHelloMessage(metadata map[string]interface{}) HelloMessage {
+	return HelloMessage{
+		metadata: metadata,
+	}
+}
+
+func (h HelloMessage) Signature() int {
+	return HelloMessageSignature
+}
+
+func (h HelloMessage) AllFields() []interface{} {
+	return []interface{}{h.metadata}
+}