Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor label filtering logic #4982

Open
blkt opened this issue Nov 15, 2024 · 0 comments
Open

Refactor label filtering logic #4982

blkt opened this issue Nov 15, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@blkt
Copy link
Contributor

blkt commented Nov 15, 2024

As per this comment, we currently allow filtering by label in two places (i.e. two endpoints), but the code to handle labels is duplicated.

In particular, the first implementation (here) handles input processing in the database layer, while the newer implementation has parameter splitting in the handler and inclusion/exclusion (i.e. label vs !label) in the service.

Refactor the older implementation into the second one, possibly reusing what is to be merged in the PR linked.

@blkt blkt added the good first issue Good for newcomers label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant