You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When I have a profile that includes the Trusty ruletype
And I create a PR that adds a dependency
Then the Minder comment on the PR does not include package alternatives, even though Trusty does have alternatives for the specific package
The text was updated successfully, but these errors were encountered:
eleftherias
added
bug
Something isn't working
P1
Fix Soon: High priority items that should be considered in the next Sprint planning cycle
labels
Nov 12, 2024
Adding an extra *altData.Score != 0 solves the issue, but we might want to (a) remove the score from display, and (b) add back description or remove that as well
diff --git i/internal/engine/eval/trusty/actions.go w/internal/engine/eval/trusty/actions.go
index 48969503a8ff..bfc8bcb9bccc 100644
--- i/internal/engine/eval/trusty/actions.go+++ w/internal/engine/eval/trusty/actions.go@@ -324,7 +324,7 @@ func (sph *summaryPrHandler) generateSummary() (string, error) {
// (2) we don't suggest malicious packages, I
// suggest getting rid of this check
// altogether.
- if altData.Score != nil && *altData.Score <= lowScorePackages[alternative.Dependency.Name].Score {+ if altData.Score != nil && *altData.Score != 0 && *altData.Score <= lowScorePackages[alternative.Dependency.Name].Score {
continue
}
Describe the issue
When I have a profile that includes the Trusty ruletype
And I create a PR that adds a dependency
Then the Minder comment on the PR does not include package alternatives, even though Trusty does have alternatives for the specific package
Example comment on PR: eleftherias/demo-repo-python#25 (review)
The screenshot below shows the comment does not include alternatives.
Note: I checked the Minder codebase and confirmed that the template still includes alternatives
minder/internal/engine/eval/trusty/actions.go
Lines 100 to 109 in 0c76dba
To Reproduce
No response
What version are you using?
No response
The text was updated successfully, but these errors were encountered: