Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move internal/entities/properties to pkg #4699

Open
JAORMX opened this issue Oct 9, 2024 · 3 comments
Open

Move internal/entities/properties to pkg #4699

JAORMX opened this issue Oct 9, 2024 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed priority: low Low priority

Comments

@JAORMX
Copy link
Contributor

JAORMX commented Oct 9, 2024

Properties are leveraged by many pieces of Minder, including providers. It should be considered a public API instead of being in our bloated internal package.

The idea is to move properties to pkg. However, we should leave the underlying service package as internal, as it's a minder-server implementation detail.

Ideally, it would move to something like pkg/entities/properties

@JAORMX JAORMX added good first issue Good for newcomers help wanted Extra attention is needed priority: low Low priority labels Oct 9, 2024
@letsmakecakes
Copy link

I can do this work

@JAORMX
Copy link
Contributor Author

JAORMX commented Oct 10, 2024

@letsmakecakes sounds good! I'll assign you. Thanks for working on this!

@JAORMX
Copy link
Contributor Author

JAORMX commented Nov 19, 2024

@letsmakecakes will you work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed priority: low Low priority
Projects
None yet
Development

No branches or pull requests

2 participants