Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fill deltalog entry num & time range in L0 compactions #33004

Conversation

congqixia
Copy link
Contributor

Resolves #33003

Signed-off-by: Congqi Xia [email protected]

@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. approved labels May 13, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 13, 2024
@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.06%. Comparing base (0e5765b) to head (6748a93).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33004      +/-   ##
==========================================
+ Coverage   82.05%   82.06%   +0.01%     
==========================================
  Files        1007     1007              
  Lines      127668   127678      +10     
==========================================
+ Hits       104757   104784      +27     
+ Misses      18929    18923       -6     
+ Partials     3982     3971      -11     
Files Coverage Δ
internal/datanode/l0_compactor.go 67.64% <100.00%> (+1.66%) ⬆️

... and 30 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 13, 2024
@sre-ci-robot sre-ci-robot merged commit 12ec3d6 into milvus-io:master May 13, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: L0 compaction generates deltalog with 0 entry num
3 participants