Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: some tests stalls unexpectedly #150

Open
kenhys opened this issue Dec 23, 2021 · 1 comment
Open

test: some tests stalls unexpectedly #150

kenhys opened this issue Dec 23, 2021 · 1 comment

Comments

@kenhys
Copy link
Contributor

kenhys commented Dec 23, 2021

Problem

There are cases that test stalls.

Actual

If test is executed respectively, it will pass.

The following test cases tend to fail apparently, but it may vary on environment.

  • test_watch_child_without_block
  • test_nothing
  • test_shift_jis_8bit
  • test_raw_shift_jis_subject

run-test.sh v -n /.../ (specified each test) will succeed, so it may be affected by executing order.

Debian: sid
Ruby: ruby 2.7.5p203 (2021-11-24 revision f69aeb8314) [x86_64-linux] (installed via rvm)

Expected

All test pass.

@kou
Copy link
Member

kou commented Jan 13, 2022

It seems that Process.waitpid is blocked when we use Milter::EventLoop#watch_child.

They are omitted or use Process.waitpid(pid, Process::WNOHANG) for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants