Tables and dividers don't render properly

[kenyee]

About this issue

This doesn't seem to render hrules/divider or tables properly..otherwise, it works great!

Example markdown:

--------------------------------------------------------------------------
A/B Test Cells (All) number is percentage of crashes with user in test cell:
----------------------------------------------------------------------------

|Test ID|Cell|% users|
|-------|----|-------
| 55977 | 6 | 15% |
| 55085 | 4 | 14% |
| 56835 | 10 | 13% |
| 57360 | 9 | 12% |

The hrule/divider makes the text within get rendered at a very large size. And the table doesn't show up:

I checked the IntelliJ library that this library uses and it appears to support tables so I'm guessing this library doesn't handle them? If so, it should be documented in the Readme.md.

Details

• [ 0.10.0 ] Used library version
• [ Compose Multiplatform 1.5.11 ] Used platform
• [ N/A ] Used support library version
• [ 8.5 ] Used gradle build tools version
• [ Iguana ] Used tooling / Android Studio version
•  Other used libraries, potential conflicting libraries

Checklist

• [ X] Searched for similar issues
• [ X] Checked out the sample application
• [ X] Read the README
• [ X] Checked out the CHANGELOG
• [ ? there is no FAQ? ] Read the FAQ
• [ X] Checked out the MIGRATION GUIDE

[mikepenz]

Thank you very much for the report @kenyee

You can find all current handled node types here:
https://github.com/mikepenz/multiplatform-markdown-renderer/blob/develop/multiplatform-markdown-renderer/src/commonMain/kotlin/com/mikepenz/markdown/compose/Markdown.kt#L86-L106

And yes you are correct, tables are currently not yet handled. It is however possible to implement a custom component which adds support for these.

That said, I am happy to review contributions adding proper table support to the library!

---

Related the hrule/divider. yes the divider on top is not shown, however the line below the text would make it a header. Which based on your screenshot looks correct. See the markdown example below:

h1

h2

---

A/B Test Cells (All) number is percentage of crashes with user in test cell:

[salah-8]

@mikepenz I don't see a table node type in the markdown library. Can you explain more how would someone implement a custom component for it?

[mikepenz]

@salah-8 you can handle custom unhandled types supported from the kotlin markdown library.
See the code here: https://github.com/mikepenz/multiplatform-markdown-renderer/blob/develop/multiplatform-markdown-renderer/src/commonMain/kotlin/com/mikepenz/markdown/compose/Markdown.kt#L108C40-L108C41

multiplatform-markdown-renderer/multiplatform-markdown-renderer/src/commonMain/kotlin/com/mikepenz/markdown/compose/components/MarkdownComponents.kt

Line 54 in 4c2fedb

custom: CustomMarkdownComponent? = CurrentComponentsBridge.custom,

[salah-8]

@mikepenz But I couldn't find a "table" type in the Kotlin markdown library in the first place to handle it here.

[mikepenz]

These might only be in the GFM flavored spec: https://github.com/JetBrains/markdown/blob/master/src/commonMain/kotlin/org/intellij/markdown/flavours/gfm/GFMElementTypes.kt#L32-L38