change translation service to MyMemory

Author: mike-ward

.gitignore

@@ -10,6 +10,7 @@
 *.userosscache
 *.sln.docstates
 *.idea
+*.DotSettings
 
 # User-specific files (MonoDevelop/Xamarin Studio)
 *.userprefs

.lite_workspace.lua

@@ -1 +1 @@
-return {["views"]={[1]={["filename"]="CHANGELOG.md",["active"]=true,["text"]=false,["scroll"]={["y"]=350,["x"]=0},["selection"]={[1]=19,[2]=63,[3]=19,[4]=63},["type"]="doc"}},["active_view"]=1,["type"]="leaf"}
+return {["active_view"]=1,["type"]="leaf",["views"]={[1]={["type"]="doc",["active"]=true,["text"]=false,["filename"]="CHANGELOG.md",["selection"]={[1]=19,[2]=1,[3]=19,[4]=1},["scroll"]={["y"]=350,["x"]=0}}}}

src/tweetz.core/Commands/TranslateCommand.cs

@@ -9,12 +9,12 @@ namespace tweetz.core.Commands
 {
     public class TranslateCommand : ICommandBinding
     {
-        private readonly       string        translateApiKey;
         public static readonly RoutedCommand Command = new RoutedUICommand();
+        private                ISettings     Settings { get; }
 
         public TranslateCommand(ISettings settings)
         {
-            translateApiKey = settings.TranslateApiKey ?? string.Empty;
+            Settings = settings;
         }
 
         public CommandBinding CommandBinding()
@@ -28,7 +28,7 @@ private async void CommandHandler(object sender, ExecutedRoutedEventArgs ea)
             var fromLang = tweet.Language ?? "und";
             var toLang   = CultureInfo.InstalledUICulture.TwoLetterISOLanguageName;
             tweet.TranslatedText = (string)Application.Current.FindResource("translate-text-working")!;
-            tweet.TranslatedText = await TranslateService.Translate(tweet.FullText, fromLang, toLang, translateApiKey).ConfigureAwait(true);
+            tweet.TranslatedText = await TranslateService.Translate(tweet.FullText, fromLang, toLang, Settings.TranslateApiKey).ConfigureAwait(true);
         }
     }
 }

src/tweetz.core/Models/Settings.cs

@@ -51,7 +51,7 @@ public Settings(IMessageBoxService messageBoxService)
         private string         fontFamily = defaultFontFamily;
         private string         theme      = "dark";
         private string?        myTweetColor;
-        private string?        translateApiKey    = "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx";
+        private string?        translateApiKey;
         private WindowPosition mainWindowPosition = new() { Left = 10, Top = 10, Width = 350, Height = 900 };
 
         [JsonIgnore]
@@ -218,6 +218,7 @@ public void Load()
                 ApplyGrayscaleShader  = settings.ApplyGrayscaleShader;
                 MyTweetColor          = settings.MyTweetColor;
                 Donated               = settings.Donated;
+                TranslateApiKey       = settings.TranslateApiKey;
                 MainWindowPosition    = settings.MainWindowPosition;
             }
             catch (Exception ex)

src/tweetz.core/Services/TranslateService.cs

@@ -1,18 +1,17 @@
 using System;
 using System.Collections.Generic;
-using System.Diagnostics.CodeAnalysis;
+using System.Net;
 using System.Net.Http;
 using System.Net.Http.Json;
-using System.Text.Json.Serialization;
 using System.Threading.Tasks;
 
 namespace tweetz.core.Services
 {
     internal static class TranslateService
     {
-        private const string endpoint = "https://libretranslate.com/translate";
+        private const string endpoint = "https://api.mymemory.translated.net/get";
 
-        public static async ValueTask<string> Translate(string? text, string fromLanguage, string toLanguage, string translateApiKey)
+        public static async ValueTask<string> Translate(string? text, string fromLanguage, string toLanguage, string? translateApiKey)
         {
             if (string.IsNullOrEmpty(text))
             {
@@ -21,33 +20,51 @@ public static async ValueTask<string> Translate(string? text, string fromLanguag
 
             try
             {
-                var request = new HttpRequestMessage {
-                    Method     = HttpMethod.Post,
-                    RequestUri = new Uri(endpoint),
-                    Content = new FormUrlEncodedContent(new[] {
-                        new KeyValuePair<string?, string?>("q", text),
-                        new KeyValuePair<string?, string?>("source", fromLanguage),
-                        new KeyValuePair<string?, string?>("target", toLanguage),
-                        new KeyValuePair<string?, string?>("api_key", translateApiKey)
-                    })
-                };
-
-                using var response = await App.MyHttpClient.SendAsync(request).ConfigureAwait(false);
-                var       result   = await response.Content.ReadFromJsonAsync<TranslatorResult>().ConfigureAwait(false);
-                return result?.TranslatedText ?? result?.ErrorText ?? "no response";
+                var       parameters     = await BuildParameters(text, fromLanguage, toLanguage, translateApiKey);
+                var       requestUri     = new Uri(endpoint + "?" + parameters);
+                using var response       = await App.MyHttpClient.GetAsync(requestUri).ConfigureAwait(false);
+                var       result         = await response.Content.ReadFromJsonAsync<TranslatorResult>().ConfigureAwait(false);
+                var       translatedText = result?.ResponseData?.TranslatedText ?? "no response";
+                var       html           = WebUtility.HtmlDecode(WebUtility.HtmlDecode(translatedText)); // Twice to handle sequences like: "&amp;mdash;"
+                return html;
             }
             catch (Exception ex)
             {
                 return ex.Message;
             }
         }
+
+        private static async Task<string> BuildParameters(string? text, string fromLanguage, string toLanguage, string? translateApiKey)
+        {
+            var pars = new List<KeyValuePair<string?, string?>> {
+                new("q", text),
+                new("langpair", $"{fromLanguage}|{toLanguage}")
+            };
+
+            // The translateApiKey is your email.
+            // Add it to your settings file.
+            // Use your own real email please.
+            // Don't abuse the MyMemoryService.
+            // https://mymemory.translated.net/doc/usagelimits.php
+
+            if (!string.IsNullOrWhiteSpace(translateApiKey)) pars.Add(new KeyValuePair<string?, string?>("de", translateApiKey));
+
+            var content    = new FormUrlEncodedContent(pars);
+            var parameters = await content.ReadAsStringAsync().ConfigureAwait(false);
+            return parameters;
+        }
     }
 
-    [SuppressMessage("ReSharper", "ClassNeverInstantiated.Global")]
+    // ReSharper disable UnusedAutoPropertyAccessor.Global
+    // ReSharper disable ClassNeverInstantiated.Global
+
     public class TranslatorResult
     {
-        // ReSharper disable once UnusedAutoPropertyAccessor.Global
-        [JsonPropertyName("translatedText")] public string? TranslatedText { get; set; }
-        [JsonPropertyName("error")]          public string? ErrorText      { get; set; }
+        public ResponseData? ResponseData { get; set; }
+    }
+
+    public class ResponseData
+    {
+        public string? TranslatedText { get; set; }
     }
 }