Skip to content

Commit 188300a

Browse files
authored
Merge pull request #46 from wtgtybhertgeghgtwtg/use-object-assign
Use `Object.assign` over `lodash.assign`.
2 parents 2f1cc67 + 256e2eb commit 188300a

File tree

4 files changed

+7
-15
lines changed

4 files changed

+7
-15
lines changed

index.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
var chalk = require('chalk');
44
var Table = require('cli-table');
5-
var assign = require('lodash.assign');
65
var cardinal = require('cardinal');
76
var emoji = require('node-emoji');
87

@@ -51,7 +50,7 @@ var defaultOptions = {
5150
};
5251

5352
function Renderer(options, highlightOptions) {
54-
this.o = assign({}, defaultOptions, options);
53+
this.o = Object.assign({}, defaultOptions, options);
5554
this.tab = sanitizeTab(this.o.tab, defaultOptions.tab);
5655
this.tableSettings = this.o.tableOptions;
5756
this.emoji = this.o.emoji ? insertEmojis : identity;
@@ -136,7 +135,7 @@ Renderer.prototype.paragraph = function(text) {
136135
};
137136

138137
Renderer.prototype.table = function(header, body) {
139-
var table = new Table(assign({}, {
138+
var table = new Table(Object.assign({}, {
140139
head: generateTableRow(header)[0]
141140
}, this.tableSettings));
142141

package-lock.json

Lines changed: 1 addition & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
"cardinal": "^2.1.1",
2626
"chalk": "^2.4.1",
2727
"cli-table": "^0.3.1",
28-
"lodash.assign": "^4.2.0",
2928
"node-emoji": "^1.4.1"
3029
},
3130
"directories": {

tests/options.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11

22
var assert = require('assert');
3-
var assign = require('lodash.assign');
43
var Renderer = require('../');
54
var marked = require('marked');
65

@@ -35,7 +34,7 @@ describe('Options', function () {
3534
});
3635

3736
it('should change tabs by space size', function () {
38-
var options = assign({}, defaultOptions, { tab: 4 });
37+
var options = Object.assign({}, defaultOptions, { tab: 4 });
3938
var r = new Renderer(options);
4039

4140
var blockquoteText = '> Blockquote'
@@ -52,7 +51,7 @@ describe('Options', function () {
5251
});
5352

5453
it('should use default tabs if passing not supported string', function () {
55-
var options = assign({}, defaultOptions, { tab: 'dsakdskajhdsa' });
54+
var options = Object.assign({}, defaultOptions, { tab: 'dsakdskajhdsa' });
5655
var r = new Renderer(options);
5756

5857
var blockquoteText = '> Blockquote'
@@ -69,7 +68,7 @@ describe('Options', function () {
6968
});
7069

7170
it('should change tabs by allowed characters', function () {
72-
var options = assign({}, defaultOptions, { tab: '\t' });
71+
var options = Object.assign({}, defaultOptions, { tab: '\t' });
7372
var r = new Renderer(options);
7473

7574
var blockquoteText = '> Blockquote'
@@ -86,7 +85,7 @@ describe('Options', function () {
8685
});
8786

8887
it('should support mulitple tab characters', function () {
89-
var options = assign({}, defaultOptions, { tab: '\t\t' });
88+
var options = Object.assign({}, defaultOptions, { tab: '\t\t' });
9089
var r = new Renderer(options);
9190

9291
var blockquoteText = '> Blockquote'

0 commit comments

Comments
 (0)