Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job type to detect dependency issues #5

Open
mikaelarguedas opened this issue Mar 19, 2019 · 0 comments
Open

Job type to detect dependency issues #5

mikaelarguedas opened this issue Mar 19, 2019 · 0 comments

Comments

@mikaelarguedas
Copy link
Owner

currently the crystal job is based on ros-base and sources all of ros_base before building. This means that if the repo needs some packages included in ros_base without declaring a dependency on them it would not be detected by CI.

Additional considerations:
It is a tradeoff as jobs would take longer and repositories with multiple packages will likely face the issues regardless as if one package declares a dependency it will be installed for the entire workspace, shadowing missing dependencies in other packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant