Nullability - IApiKeyProvider.ProvideAsync should return Task<IApiKey?>

[skyflyer]

Hello!

Thanks for the library 🙏!

Would you agree that it would be proper that the method declaration (ProvideAsync) in the IApiKeyProvider interface should return nullable value since it is explicitly checked in the handler? That way, no compiler warnings would be present (or escape hatches with !) 😄

[renerlemes]

@skyflyer when the user is not authenticated by your implementation, it must return

return await Task.FromResult<IApiKey>(null);

[skyflyer]

Sure, but the compiler will warn, because you're returning null when the interface definition does not define that a return type is nullable. That's all I'm saying. :)

[renerlemes]

I didn't really understand your question, I understood that you wanted to know how to return the value.
Reading better now, I understand and agree that it should be nullable.

Sorry 😄

[esbenbach]

@renerlemes Willing to accept PRs for this change?

[renerlemes]

@esbenbach some time that does not update anything in the repository. But I think I can make PR and maybe the owner approve. I do not have this permission.

[mihirdilip]

@skyflyer / @esbenbach / @renerlemes
Thank you for using the library and your feedback. Apologies for late update. New version is now available with Nullability support. https://www.nuget.org/packages/AspNetCore.Authentication.ApiKey/9.0.0