-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nullability - IApiKeyProvider.ProvideAsync should return Task<IApiKey?> #42
Comments
@skyflyer when the user is not authenticated by your implementation, it must return
|
Sure, but the compiler will warn, because you're returning |
I didn't really understand your question, I understood that you wanted to know how to return the value. Sorry 😄 |
Hello!
Thanks for the library 🙏!
Would you agree that it would be proper that the method declaration (
ProvideAsync
) in theIApiKeyProvider
interface should return nullable value since it is explicitly checked in the handler? That way, no compiler warnings would be present (or escape hatches with!
) 😄The text was updated successfully, but these errors were encountered: