Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using deprecated as tracking flag, minor fixes #42

Open
yuliannabn opened this issue Oct 11, 2024 · 0 comments
Open

Stop using deprecated as tracking flag, minor fixes #42

yuliannabn opened this issue Oct 11, 2024 · 0 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@yuliannabn
Copy link
Collaborator

yuliannabn commented Oct 11, 2024

Context

Due to the deprecated flag determining if the node is being tracked or not, a node can be incorrectly flagged as non-deprecated when its true state is not yet known. This happens whenever a deprecated node (which is deleted from the tracking list) is found again, and due to being now seen as a "new node", the deprecation flag is changed to false (default) regardless of its previous state, making it temporally (and incorrectly) non-deprecated until time is exhausted.
A workaround to this can be to keep its previous deprecation state unless proven otherwise, and use another column to determine if the node is currently being tracked or not.

Tasks

  • Correct first_connected to use coalesce to store it. Currently, first_connected is not being saved at all.
  • last_error column -> Make this column include ErrorNone.
  • New column is_tracked -> boolean, use to track if the node is in the watchlist or not.
  • deprecated -> do not change unless needed.
  • Print current deprecation time in startup logs.
@yuliannabn yuliannabn added bug Something isn't working enhancement New feature or request labels Oct 11, 2024
@yuliannabn yuliannabn self-assigned this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant