Fullscreen support

[viliusle]

https://developer.mozilla.org/en-US/docs/Web/API/Fullscreen_API

p.s. priority is low, but it would be nice to have for users with big screens watching high resolutions images.

[viliusle]

Actually same affect can be achieved by pressing full screen shortcut. And extra button means more UI elements, and more distraction from content/image itself.

p.s. I am not sure if it should be implemented anymore. If there will be no other opinions, I will close this ticket.

[midzer]

Yeah, I go with your opinion. Let's close this one for good.

If anyone wants to discuss this again, feel free to re-open.

[viliusle]

I want to bring this back, lets keep ticket open to allow discussion. Everybody, please share your opinion.

Reason to implement: most advanced users does not need it, they can press F11/fn+F button. But there are so many people that dont know technology well, they dont know how to enter full screen mode so this feature can help them a lot.

Go to https://en.wikipedia.org/wiki/Jungle, click on first image (state 1). Now enter full screen (there is icon, state 2). UX difference is huge on big screen.

Big issue would be finding place for that button.

p.s. implementation should be simple, only for images.

[midzer]

Thanks for re-opening, @viliusle

Yes, I'm in favor to bring more features to Tobii. The library is tiny in size given all the functionality.

Fullscreen support is a nice thing to have, no only for advanced users. Same as with a Download button which was planned already (would be a separate issue)

tobii/src/js/index.js

Line 112 in a329b93

download: false, // TODO

How about introducing the "Toggle fullscreen" button at the bottom left? A possible "Download element" could fit next to it, too.

Why bottom left? -> "X" button is top right. For me those new features are in direct contrast to a close functionality.

I'm open for more ideas and arguments though. All feature buttons below the "X" for example, like in Wikipedia.

[viliusle]

I would like bottom right corner, features going up, like in Wikipedia. Because I (and maybe others?) don't look much at left side and don't expect buttons there. Because close button is always on right side, I would expect additional button also on right side, bottom left corner would be last place to look. But it may be only me. Just sharing my ideas.

[midzer]

@viliusle Your explanation convinced me. Yeah, let's do it this way.

Would be happy to review a PR.