Skip to content

Is there a specific reason for not allowing multiple instances of Tobii on the same page? #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mably opened this issue Feb 11, 2025 · 3 comments

Comments

@mably
Copy link
Contributor

mably commented Feb 11, 2025

For accessibility reason we need to be able to specify distinct modal dialog titles for every lightboxes we have on our page.

After disabling the code forbidding multiple Tobii instances creation, everything seems to be working fine?

Do you know for what reason it shouldn't be used? Or what are the risk to do so?

@midzer
Copy link
Owner

midzer commented Feb 11, 2025

I haven't tested multiple Tobii instances yet.

#103 is related.

@mably
Copy link
Contributor Author

mably commented Feb 11, 2025

Ok, just seen that issue, thanks 👍

At first look it seems to be working fine, we'll enable it on our site to test it more extensively.

EDIT:

A test page with multiple Tobii instances (check the Tobii dialogs with different aria-label) :

https://bdxfr.e-bordeauxmetropole.org/une-page-editoriale-de-test-pour-les-composants-images-videos-audios

@midzer
Copy link
Owner

midzer commented Feb 11, 2025

Good.

Once more testing has gone into this, feel free to PR it.

Afterwards I will consider releasing a new version with your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants