Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve default RetryHandler implementation #2186

Open
Geiste opened this issue Oct 7, 2024 · 2 comments
Open

Improve default RetryHandler implementation #2186

Geiste opened this issue Oct 7, 2024 · 2 comments
Labels
Needs: Attention 👋 type:enhancement Enhancement request targeting an existing experience type:legacy-version Old version of the SDK

Comments

@Geiste
Copy link

Geiste commented Oct 7, 2024

Is your feature request related to a problem? Please describe the problem.

SDK V5
As per incident: 2409111420000033
in case there is a low memory on server side the server returns 503 for other error codes.

In such cases SDK treats 404, 403 errors as if it is 503 and retries.

We were instructed by Microsoft support person of contact to implement RetryHandler on application side and retry only if "retry-after" header is present. However, it sounds like this should be handled in SDK side rather than us.

Describe the solution you'd like.

I would propose such cases, when Microsoft servers have low memory to be handled by SDK

Additional context?

No response

@Geiste Geiste added status:waiting-for-triage An issue that is yet to be reviewed or assigned type:feature New experience request labels Oct 7, 2024
@Ndiritu
Copy link
Contributor

Ndiritu commented Oct 8, 2024

Hi @Geiste, are you referencing an IcM incident number? I'm unable to find one with that number.
Please share a link.

Unfortunately we are currently only doing security patches for v5 and would recommend you upgrade to v6 of the SDK which correctly handles retries

@Ndiritu Ndiritu added type:legacy-version Old version of the SDK type:enhancement Enhancement request targeting an existing experience status:waiting-for-author-feedback Issue that we've responded but needs author feedback to close and removed status:waiting-for-triage An issue that is yet to be reviewed or assigned type:feature New experience request labels Oct 8, 2024
@Geiste
Copy link
Author

Geiste commented Oct 8, 2024 via email

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 and removed status:waiting-for-author-feedback Issue that we've responded but needs author feedback to close labels Oct 8, 2024
@baywet baywet added status:waiting-for-author-feedback Issue that we've responded but needs author feedback to close and removed status:waiting-for-author-feedback Issue that we've responded but needs author feedback to close labels Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Attention 👋 type:enhancement Enhancement request targeting an existing experience type:legacy-version Old version of the SDK
Projects
None yet
Development

No branches or pull requests

3 participants