-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What happened to DefaultLogger and the ability to set the logging level? #1961
Comments
Another path that went "poof" was: client.sites().byId(config.getSiteId()).drive().root().itemWithPath("folder/file"); I totally expect breaking changes going from 5.x.x to 6.x.x but the issue I'm facing is that I can't find a suitable replacement. I'm now stuck either using 6.x.x to get access to publishing site pages or using 5.x.x to access drive items to convert PDFs and I can't seem to do both with one version. |
@baywet requesting your help on how to configure OpenTelemetry to work with the SDK. Will add to docs. |
@jdimeo You would need to fetch the drive then use it's ID to get the item: var drive = client.sites().bySiteId(config.getSiteId()).drive().get();
var driveItem = client.drives().byDriveId(drive.getId()).items().byDriveItemId("root:/folder/file:").get(); |
@Ndiritu sure!
Then kiota layers also implement additional tracing through open telemetry, it's being sent automatically, the only thing that's required it to start exporting those where-ever required. |
Thank you for the clarification. While I totally understand the motivation here, this is going to be really hard for users because now the SDK won't match what is written in the public API docs. I've continually gotten "stuck" with 6.x.x because as I find an endpoint in the API docs that does exactly what I want, but I can't find it in the SDK, and I don't necessarily have the knowledge to know what is canonical vs. convenience. |
Getting a philosophical here, my understanding of "SDK" - software development kit - is that intentionally is a "kit" of tools that make developing software to use the API easy. So I would expect convenience features like setting log to The way AWS reduces size is to break out the client code by product/tool/service, but also provide a BOM if you need to mix and match multiple. |
@mkomko you don't set the level anymore. You configure your application with OpenTelemetry filters and exporters instead (see my previous reply) |
Expected behavior
The
DefaultLogger
class was removed as was theGraphServiceClient.builder()
which had alogger()
with no obvious replacement. Do we have to access low levelOkHttp
to add a logging interceptor? All I want to do is set logging toDEBUG
vs.INFO
based on the user's config.Actual behavior
No way to easily set the logging level.
Steps to reproduce the behavior
I migrated from 5.77.0 to 6.6.0
The text was updated successfully, but these errors were encountered: