Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong/confusing generation of properties (e.g IPv4 => i_pv4,) #181

Closed
haavardw opened this issue Aug 22, 2023 · 1 comment
Closed

Wrong/confusing generation of properties (e.g IPv4 => i_pv4,) #181

haavardw opened this issue Aug 22, 2023 · 1 comment
Assignees

Comments

@haavardw
Copy link

There's some rather confusing and annoying property names being generated. Even my github copilot gets this wrong.

Example: msgraph.generated.models.ti_indicator.TiIndicator has translated the field "networkIPv4" to the class property network_i_pv4. There's plenty of similar cases just in this class.

A better (IMO) translation would be network_ip_v4 or network_ipv4.

@rkodev
Copy link

rkodev commented Jul 12, 2024

Hi @haavardw , thanks for Trying out the Graph Python SDK. This issue is currently being addressed on the Kiota repo , which is responsible for generation of this SDK. Please feel free to follow the conversation there for more information

@rkodev rkodev closed this as completed Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants