Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Package Issue]: Cyanfish.NAPS2 #192354

Open
2 tasks done
DeviateFromThePlan opened this issue Nov 19, 2024 · 2 comments
Open
2 tasks done

[Package Issue]: Cyanfish.NAPS2 #192354

DeviateFromThePlan opened this issue Nov 19, 2024 · 2 comments
Labels
Help-Wanted This is a good candidate work item from the community. Issue-Bug It either shouldn't be doing this or needs an investigation. Upgrade-Issue Issue with the package's installer while upgrading a package's version.

Comments

@DeviateFromThePlan
Copy link
Contributor

Please confirm these before moving forward

  • I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
  • I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue

No applicable update found.

Brief description of your issue

When I run winget list in cmd, NAPS2 shows an ID of ARP\Machine\X64\NAPS2 - Not Another PDF Scanner_is1, not associating correctly with the winget ID. This means it isn't getting updates. From looking in the manifest, I figured out changing the product code to the one I mentioned above, it picked up, however changing this would leave the people with the other ID in the dark. Is there a way to have both?

Steps to reproduce

Install NAPS2 from the regular website, then try and update with winget.

Actual behavior

Can't associate local install to winget ID.

Expected behavior

Should all connect.

Environment

Windows Package Manager v1.9.25200
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.26100.1882
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.24.25200.0

Winget Directories
-----------------------------------------------------------------------------------------------------------------------
Logs                               %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\Diag…
User Settings                      %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\sett…
Portable Links Directory (User)    %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User)       %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root              C:\Program Files\WinGet\Packages
Portable Package Root (x86)        C:\Program Files (x86)\WinGet\Packages
Installer Downloads                %USERPROFILE%\Downloads

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Admin Setting                             State
--------------------------------------------------
LocalManifestFiles                        Enabled
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride                     Disabled
LocalArchiveMalwareScanOverride           Disabled
ProxyCommandLineOptions                   Disabled
DefaultProxy                              Disabled

Screenshots and Logs

No response

@DeviateFromThePlan DeviateFromThePlan added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Nov 19, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label Nov 19, 2024
@stephengillie stephengillie added Upgrade-Issue Issue with the package's installer while upgrading a package's version. Help-Wanted This is a good candidate work item from the community. and removed Needs-Triage This work item needs to be triaged by a member of the core team. labels Nov 19, 2024
@stephengillie
Copy link
Collaborator

If I'm understanding correctly:

  1. Installing through the package manager results in one ProductCode being written to the Registry
  2. Installing manually then upgrading with the package manager results in a different ProductCode being written to the Registry.

As you mentioned, the latest manifest has the 1st ProductCode. I do not know of a way to specify 2 ProductCodes, but I believe that removing the value here would allow the package manager to treat it as a wildcard. If there are still enough other correllating bits in the manifest, then it should fix this Issue while leaving other users unaffected.

CC @krystofkrticka, author of that PR. What are your thoughts on this Issue? Should the ProductCode be removed here?

@DeviateFromThePlan
Copy link
Contributor Author

I should also note that I tried removing all the product codes and it still wouldn't recognise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help-Wanted This is a good candidate work item from the community. Issue-Bug It either shouldn't be doing this or needs an investigation. Upgrade-Issue Issue with the package's installer while upgrading a package's version.
Projects
None yet
Development

No branches or pull requests

2 participants