Skip to content

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Oct 3, 2025

Note

This is a codeflow update. It may contain both source code changes from the VMR as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/dotnet

Updated Dependencies

Associated changes in source repos

Updated Dependencies:
Microsoft.Diagnostics.NETCore.Client (Version 0.2.0-preview.25476.104 -> 0.2.0-preview.25479.115)
@nohwnd
Copy link
Member

nohwnd commented Oct 7, 2025

@premun were you setting this flow up? Code coverage version should for sure stay 18.0.4 on the release branch.

<Source Uri="https://github.com/dotnet/dotnet" Mapping="vstest" Sha="e1eaf1bbd9702e9b6ee9b10dbc94105732e07896" BarId="284895" />
<Source Uri="https://github.com/dotnet/dotnet" Mapping="vstest" Sha="e72b5bbe719d747036ce9c36582a205df9f1c361" BarId="285185" />
<ProductDependencies>
<Dependency Name="Microsoft.Internal.CodeCoverage" Version="18.0.0-preview.25469.1">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nohwnd the value was most likely taken from here because the other file is generated automatically always.
I see this change 740c683 that only changed the auto-generated file (see its header)

What is your goal with this? Do you wish to lock this dependency at 18.0.4?

I'd suggest changing the V.D.xml file as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, locking the dependency to that version.

Copy link
Member

@premun premun Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you do have other subscriptions that might override this, you can put Pinned="true" in V.D.xml for this dependency.
Or you can alternatively set SkipProperty="true" which will stop generating it in V.D.props and then define it in Versions.props where it will stay.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Oct 8, 2025

Important

The source repository has received code changes from an opposite flow. Any additional codeflows into this PR may potentially result in lost changes.
Please continue with one of the following options:

  1. Close or merge this PR and let the codeflow continue normally
  2. Close or merge this PR and receive the new codeflow immediately by triggering the subscription:
    darc trigger-subscriptions --id 1da85182-4376-4dec-8e48-24e268368e78
  3. Force-flow new changes into this PR at your own risk (some PR commits might be reverted):
    darc trigger-subscriptions --force --id 1da85182-4376-4dec-8e48-24e268368e78

In case of unclarities, consult the FAQ or tag @dotnet/product-construction for assistance.

Copy link
Member

@nohwnd nohwnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have to do the changes described above when I have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants