-
Notifications
You must be signed in to change notification settings - Fork 339
[rel/18.0] Source code updates from dotnet/dotnet #15288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rel/18.0
Are you sure you want to change the base?
[rel/18.0] Source code updates from dotnet/dotnet #15288
Conversation
Updated Dependencies: Microsoft.Diagnostics.NETCore.Client (Version 0.2.0-preview.25476.104 -> 0.2.0-preview.25479.115)
|
@premun were you setting this flow up? Code coverage version should for sure stay 18.0.4 on the release branch. |
| <Source Uri="https://github.com/dotnet/dotnet" Mapping="vstest" Sha="e1eaf1bbd9702e9b6ee9b10dbc94105732e07896" BarId="284895" /> | ||
| <Source Uri="https://github.com/dotnet/dotnet" Mapping="vstest" Sha="e72b5bbe719d747036ce9c36582a205df9f1c361" BarId="285185" /> | ||
| <ProductDependencies> | ||
| <Dependency Name="Microsoft.Internal.CodeCoverage" Version="18.0.0-preview.25469.1"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nohwnd the value was most likely taken from here because the other file is generated automatically always.
I see this change 740c683 that only changed the auto-generated file (see its header)
What is your goal with this? Do you wish to lock this dependency at 18.0.4?
I'd suggest changing the V.D.xml file as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, locking the dependency to that version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you do have other subscriptions that might override this, you can put Pinned="true" in V.D.xml for this dependency.
Or you can alternatively set SkipProperty="true" which will stop generating it in V.D.props and then define it in Versions.props where it will stay.
|
Important The source repository has received code changes from an opposite flow. Any additional codeflows into this PR may potentially result in lost changes.
In case of unclarities, consult the FAQ or tag @dotnet/product-construction for assistance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will have to do the changes described above when I have time.
Note
This is a codeflow update. It may contain both source code changes from the VMR as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/dotnet/dotnet
Updated Dependencies
Associated changes in source repos