Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider reading sources even when some types cannot load #4832

Closed
nohwnd opened this issue Jan 18, 2024 · 0 comments
Closed

Consider reading sources even when some types cannot load #4832

nohwnd opened this issue Jan 18, 2024 · 0 comments

Comments

@nohwnd
Copy link
Member

nohwnd commented Jan 18, 2024

Due to library mismatch, some types might fail to load from the assembly when PortableReader is used. This ends up throwing TypeLoadException, and skipping the whole source lookup. Which means no tests in the assembly will have source information.

This exception can be swallowed and the types that were loaded from the assembly can be read from the exception properties, which should allow us to return the data we were able to gather without skipping the others.

See this PR for the description of the problem, a piece of code in static method loaded roslyn types, and those failed to load an older version of System.Collections.Immutable.

dotnet/fsharp#16545 (review)

@nohwnd nohwnd closed this as not planned Won't fix, can't repro, duplicate, stale Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant