Skip to content

Commit b538cd4

Browse files
nohwndCopilot
nohwnd
and
Copilot
committed
Remove no-op binding redirects from app.configs
Remove binding redirects that were no-ops (all assembly references in the dependency graph already target the shipped version): - System.Collections.Immutable (8.0.0.0) - System.Reflection.Metadata (8.0.0.0) - System.Memory (4.0.1.2) - Microsoft.Extensions.FileSystemGlobbing (8.0.0.0) - System.Diagnostics.DiagnosticSource (8.0.0.0) - System.Text.Encodings.Web (8.0.0.0) - System.Runtime.CompilerServices.Unsafe (6.0.0.0) [vstest.console only] Remaining redirects are genuinely needed: - ObjectModel 11-15 -> 15 (backward compat with old adapters) - CompilerServices.Unsafe 1-6 -> 6 (System.Memory 4.5.5 refs 4.0.4.1) - TestWindow.Interfaces 11-18 -> 18 (VS integration, testhost.x86) - UnitTestFramework 10.1 -> 10.0 (MSTest v1 compat, testhost.x86) Validated with assembly reference checker tool (PEReader/MetadataReader) and acceptance tests (372 passed, 104 skipped due to pre-existing test asset build issue, 23 skipped). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 6c696b1 commit b538cd4

3 files changed

Lines changed: 3 additions & 59 deletions

File tree

‎src/datacollector/app.config‎

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -16,26 +16,11 @@
1616
<assemblyIdentity name="Microsoft.VisualStudio.TestPlatform.ObjectModel" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
1717
<bindingRedirect oldVersion="11.0.0.0-14.0.0.0" newVersion="15.0.0.0" />
1818
</dependentAssembly>
19-
<dependentAssembly>
20-
<assemblyIdentity name="Microsoft.Extensions.FileSystemGlobbing" publicKeyToken="adb9793829ddae60" culture="neutral" />
21-
<bindingRedirect oldVersion="1.0.0.0-2.0.0.0" newVersion="2.0.0.0" />
22-
</dependentAssembly>
19+
<!-- System.Memory 4.5.5 references CompilerServices.Unsafe 4.0.4.1 but we ship 6.0.0.0 (from SCI/SRM). -->
2320
<dependentAssembly>
2421
<assemblyIdentity name="System.Runtime.CompilerServices.Unsafe" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
2522
<bindingRedirect oldVersion="1.0.0.0-6.0.0.0" newVersion="6.0.0.0" />
2623
</dependentAssembly>
27-
<dependentAssembly>
28-
<assemblyIdentity name="System.Collections.Immutable" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
29-
<bindingRedirect oldVersion="1.0.0.0-8.0.0.0" newVersion="8.0.0.0" />
30-
</dependentAssembly>
31-
<dependentAssembly>
32-
<assemblyIdentity name="System.Reflection.Metadata" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
33-
<bindingRedirect oldVersion="1.0.0.0-8.0.0.0" newVersion="8.0.0.0" />
34-
</dependentAssembly>
35-
<dependentAssembly>
36-
<assemblyIdentity name="System.Memory" publicKeyToken="cc7b13ffcd2ddd51" culture="neutral" />
37-
<bindingRedirect oldVersion="0.0.0.0-4.0.1.2" newVersion="4.0.1.2" />
38-
</dependentAssembly>
3924
</assemblyBinding>
4025
</runtime>
4126
</configuration>

‎src/testhost.x86/app.config‎

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -24,26 +24,11 @@
2424
<assemblyIdentity name="Microsoft.VisualStudio.QualityTools.UnitTestFramework" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
2525
<bindingRedirect oldVersion="10.1.0.0" newVersion="10.0.0.0" />
2626
</dependentAssembly>
27-
<dependentAssembly>
28-
<assemblyIdentity name="Microsoft.Extensions.FileSystemGlobbing" publicKeyToken="adb9793829ddae60" culture="neutral" />
29-
<bindingRedirect oldVersion="1.0.0.0-2.0.0.0" newVersion="2.0.0.0" />
30-
</dependentAssembly>
27+
<!-- System.Memory 4.5.5 references CompilerServices.Unsafe 4.0.4.1 but we ship 6.0.0.0 (from SCI/SRM). -->
3128
<dependentAssembly>
3229
<assemblyIdentity name="System.Runtime.CompilerServices.Unsafe" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
3330
<bindingRedirect oldVersion="1.0.0.0-6.0.0.0" newVersion="6.0.0.0" />
3431
</dependentAssembly>
35-
<dependentAssembly>
36-
<assemblyIdentity name="System.Collections.Immutable" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
37-
<bindingRedirect oldVersion="1.0.0.0-8.0.0.0" newVersion="8.0.0.0" />
38-
</dependentAssembly>
39-
<dependentAssembly>
40-
<assemblyIdentity name="System.Reflection.Metadata" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
41-
<bindingRedirect oldVersion="1.0.0.0-8.0.0.0" newVersion="8.0.0.0" />
42-
</dependentAssembly>
43-
<dependentAssembly>
44-
<assemblyIdentity name="System.Memory" publicKeyToken="cc7b13ffcd2ddd51" culture="neutral" />
45-
<bindingRedirect oldVersion="0.0.0.0-4.0.1.2" newVersion="4.0.1.2" />
46-
</dependentAssembly>
4732
</assemblyBinding>
4833
</runtime>
4934
<system.diagnostics>

‎src/vstest.console/app.config‎

Lines changed: 1 addition & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -16,37 +16,11 @@
1616
<assemblyIdentity name="Microsoft.VisualStudio.TestPlatform.ObjectModel" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
1717
<bindingRedirect oldVersion="11.0.0.0-15.0.0.0" newVersion="15.0.0.0" />
1818
</dependentAssembly>
19-
<dependentAssembly>
20-
<assemblyIdentity name="Microsoft.Extensions.FileSystemGlobbing" publicKeyToken="adb9793829ddae60" culture="neutral" />
21-
<bindingRedirect oldVersion="1.0.0.0-2.0.0.0" newVersion="2.0.0.0" />
22-
</dependentAssembly>
19+
<!-- System.Memory 4.5.5 references CompilerServices.Unsafe 4.0.4.1 but we ship 6.0.0.0 (from SCI/SRM). -->
2320
<dependentAssembly>
2421
<assemblyIdentity name="System.Runtime.CompilerServices.Unsafe" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
2522
<bindingRedirect oldVersion="1.0.0.0-6.0.0.0" newVersion="6.0.0.0" />
2623
</dependentAssembly>
27-
<dependentAssembly>
28-
<assemblyIdentity name="System.Collections.Immutable" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
29-
<bindingRedirect oldVersion="1.0.0.0-8.0.0.0" newVersion="8.0.0.0" />
30-
</dependentAssembly>
31-
<dependentAssembly>
32-
<assemblyIdentity name="System.Reflection.Metadata" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
33-
<bindingRedirect oldVersion="1.0.0.0-8.0.0.0" newVersion="8.0.0.0" />
34-
</dependentAssembly>
35-
36-
<dependentAssembly>
37-
<assemblyIdentity name="System.Memory" publicKeyToken="cc7b13ffcd2ddd51" culture="neutral" />
38-
<bindingRedirect oldVersion="0.0.0.0-4.0.1.2" newVersion="4.0.1.2" />
39-
</dependentAssembly>
40-
41-
<dependentAssembly>
42-
<assemblyIdentity name="System.Diagnostics.DiagnosticSource" publicKeyToken="cc7b13ffcd2ddd51" culture="neutral" />
43-
<bindingRedirect oldVersion="0.0.0.0-8.0.0.1" newVersion="8.0.0.0" />
44-
</dependentAssembly>
45-
46-
<dependentAssembly>
47-
<assemblyIdentity name="System.Text.Encodings.Web" publicKeyToken="cc7b13ffcd2ddd51" culture="neutral" />
48-
<bindingRedirect oldVersion="0.0.0.0-6.0.0.1" newVersion="6.0.0.1" />
49-
</dependentAssembly>
5024
</assemblyBinding>
5125
</runtime>
5226
<appSettings>

0 commit comments

Comments
 (0)