Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process Explorer shows limited info about Window/EH #212111

Open
rebornix opened this issue May 6, 2024 · 8 comments
Open

Process Explorer shows limited info about Window/EH #212111

rebornix opened this issue May 6, 2024 · 8 comments
Assignees
Labels
papercut 🩸 A particularly annoying issue impacting someone on the team workbench-diagnostics General VS Code built-in diagnostic issues

Comments

@rebornix
Copy link
Member

rebornix commented May 6, 2024

Right now the process explorer no longer shows the relationship between Window (renderer process) and EH, making it harder to tell which extension was enabled for which Window/workspace. For example, in the screenshot below, I'd love to know why Deno was activated, but couldn't tell from the explorer.

image

@rebornix
Copy link
Member Author

rebornix commented May 6, 2024

cc @deepak1556 as well.

Was this a change from the recent underling package update or it's how we create EH now (from the main process)?

@rebornix rebornix added the papercut 🩸 A particularly annoying issue impacting someone on the team label May 6, 2024
@rebornix
Copy link
Member Author

rebornix commented May 6, 2024

Just learnt that [x] suffix can be used to identify which window each process belongs to. Maybe we could group them in the Process Explorer UI.

@bpasero
Copy link
Member

bpasero commented May 6, 2024

That is true, the number points to the window. Note that the list does not update live when you keep process explorer open because the info about which process belongs to which window is only sent initially.

I think @Tyriar is the owner of process explorer, not sure though if thats the latest in ownership.

@bpasero bpasero added the workbench-diagnostics General VS Code built-in diagnostic issues label May 6, 2024
@deepak1556
Copy link
Contributor

Was this a change from the recent underling package update or it's how we create EH now (from the main process)?

The current view replicates the actual process hierarchy, (i-e) EH, shared process, pty host are created from the main process and not from the window. [x] was added to relate these process to the corresponding window as you have figured out.

Maybe we could group them in the Process Explorer UI.

Yeah this should be possible, but it would not then reflect the actual process hierarchy is that still okay ?

@deepak1556 deepak1556 assigned Tyriar and unassigned rzhao271 May 7, 2024
@bpasero
Copy link
Member

bpasero commented May 7, 2024

I actually think we should reflect the true process hierarchy and not some logical grouping. The idea of the process explorer was (as far as I remember) to show the true hierarchy.

@rebornix
Copy link
Member Author

rebornix commented May 7, 2024

I guess I'm asking for an enhancement for the Process Explorer to help us troubleshoot perf/memory issues. Maybe this can be a mode, where processes for the same window/workspace can be grouped together so users can easily tell which workspace is behaving poorly.

Since I have too many extensions, each time when I update Insiders, my mac will run at 800% CPU for half a minute. Thus I moved to Profile almost per workspace (one for VS Code, one for Jupyter and another for Copilot). This is why I want a better view to help me understand if an EH for a particular profile is under performing.

@rebornix
Copy link
Member Author

rebornix commented May 7, 2024

Here is another example

image

I have a dozen conpty-agent and I don't know where do they come from (which workspace/extensions started them)

@bpasero
Copy link
Member

bpasero commented May 8, 2024

@rebornix but I think for pty host we really have no tracking to the related window id, so that is really missing from the list, even if we had logical grouping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
papercut 🩸 A particularly annoying issue impacting someone on the team workbench-diagnostics General VS Code built-in diagnostic issues
Projects
None yet
Development

No branches or pull requests

5 participants