From 4268e464763087044d0c1b5bdd37ebbe683cadfa Mon Sep 17 00:00:00 2001 From: Michael Lively Date: Fri, 29 Sep 2023 13:06:50 -0700 Subject: [PATCH] fix nb codeactions running on autosave when set `true` [release] (#194500) fix nb codeactions running on autosave when set `true` --- .../browser/contrib/saveParticipants/saveParticipants.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/notebook/browser/contrib/saveParticipants/saveParticipants.ts b/src/vs/workbench/contrib/notebook/browser/contrib/saveParticipants/saveParticipants.ts index 574945c4f870a..1195c7767b206 100644 --- a/src/vs/workbench/contrib/notebook/browser/contrib/saveParticipants/saveParticipants.ts +++ b/src/vs/workbench/contrib/notebook/browser/contrib/saveParticipants/saveParticipants.ts @@ -329,7 +329,8 @@ class CodeActionOnSaveParticipant implements IStoredFileWorkingCopySaveParticipa if (context.reason === SaveReason.AUTO) { // currently this won't happen, as vs/editor/contrib/codeAction/browser/codeAction.ts L#104 filters out codeactions on autosave. Just future-proofing // ? notebook CodeActions on autosave seems dangerous (perf-wise) - saveTrigger = 'always'; + // saveTrigger = 'always'; // TODO@Yoyokrazy, support during debt + return undefined; } else if (context.reason === SaveReason.EXPLICIT) { saveTrigger = 'explicit'; } else {