Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[x-plane] The core xplm and xpwidgets libraries are not copied into <triplet>\lib on Windows. #43384

Open
jamarr81 opened this issue Jan 21, 2025 · 2 comments
Assignees
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@jamarr81
Copy link

Describe the bug
The core XPLM_64.lib and XPWidgets_64.lib libraries are not copied into <triplet>\lib or <triplet>\debug\lib. This project distributes its own prebuilt static libraries from zip archives. These two files can be found in the Libraries\Win archive subdirectory. The portfile.cmake (or unofficial CMakeLists.txt?) should only need to copy these files into the respective \lib folders.

Environment

  • OS: Windows 11
  • Compiler: MSVS 2022

To Reproduce
Steps to reproduce the behavior:

  1. Add the x-plane dependency.
  2. Build x-plane for (Windows) <triplet>.
  3. Check <x-install-root>\<triplet>\lib and <x-install-root>\<triplet>\debug\lib

Expected behavior
The core XPLM_64.lib and XPWidgets_64.lib libraries should be copied into <triplet>\lib and <triplet>\debug\lib.

Failure logs
n/a

Additional context
This project includes 2 core libraries: xplm and xpwidgets; and 1 optional (wrapper) library: xpc. The core libraries are prebuilt static libraries. The optional library has to be compiled. This port currently copies the headers for all 3 libraries into the <triplet>\include directory. This port also compiles and copies the optional xpc library into the \lib directories as xplm_cpp.lib. However, it is not copying the more significant core libraries into the \lib directories.

@WangWeiLin-MV WangWeiLin-MV added the requires:repro The issue is not currently repro-able label Jan 22, 2025
@jamarr81
Copy link
Author

jamarr81 commented Jan 22, 2025

@WangWeiLin-MV, did you mean to tag this as requires:repro? Also, I'm curious if you're aware, but adding a label does not seem to notify the ticket author, so a comment explaining the label would have been helpful.

I'm unfamiliar with msft/vcpkg labels, but assuming it means you could not reproduce the issue and then assuming this label was intentional, I'm curious about what environment you're using. I can reproduce this on two different Windows 11 systems following the To Reproduce steps.

Image

The XPLM_64.lib and XPWidgets_64.lib files from Libraries\Win are missing.

Image

@WangWeiLin-MV
Copy link
Contributor

Thanks for your detailed comment, I reproduce it locally.

@WangWeiLin-MV WangWeiLin-MV added category:port-bug The issue is with a library, which is something the port should already support and removed requires:repro The issue is not currently repro-able labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

No branches or pull requests

2 participants