Check patterns for validity before putting them into pattern ambient modules (#875)

Co-authored-by: Daniel Rosenwasser <[email protected]>

Author: andrewbranch

internal/binder/binder.go

@@ -797,18 +797,18 @@ func (b *Binder) bindModuleDeclaration(node *ast.Node) {
 		if ast.IsModuleAugmentationExternal(node) {
 			b.declareModuleSymbol(node)
 		} else {
-			var pattern core.Pattern
 			name := node.AsModuleDeclaration().Name()
+			symbol := b.declareSymbolAndAddToSymbolTable(node, ast.SymbolFlagsValueModule, ast.SymbolFlagsValueModuleExcludes)
+
 			if ast.IsStringLiteral(name) {
-				pattern = core.TryParsePattern(name.AsStringLiteral().Text)
+				pattern := core.TryParsePattern(name.AsStringLiteral().Text)
 				if !pattern.IsValid() {
+					// An invalid pattern - must have multiple wildcards.
 					b.errorOnFirstToken(name, diagnostics.Pattern_0_can_have_at_most_one_Asterisk_character, name.AsStringLiteral().Text)
+				} else if pattern.StarIndex >= 0 {
+					b.file.PatternAmbientModules = append(b.file.PatternAmbientModules, &ast.PatternAmbientModule{Pattern: pattern, Symbol: symbol})
 				}
 			}
-			symbol := b.declareSymbolAndAddToSymbolTable(node, ast.SymbolFlagsValueModule, ast.SymbolFlagsValueModuleExcludes)
-			if pattern.StarIndex >= 0 {
-				b.file.PatternAmbientModules = append(b.file.PatternAmbientModules, &ast.PatternAmbientModule{Pattern: pattern, Symbol: symbol})
-			}
 		}
 	} else {
 		state := b.declareModuleSymbol(node)

testdata/baselines/reference/compiler/invalidGlobalAugmentation.errors.txt

@@ -0,0 +1,19 @@
+globals.ts(1,9): error TS2669: Augmentations for the global scope can only be directly nested in external modules or ambient module declarations.
+react-native.ts(2,16): error TS2664: Invalid module name in augmentation, module 'react-native' cannot be found.
+
+
+==== globals.ts (1 errors) ====
+    declare global {
+            ~~~~~~
+!!! error TS2669: Augmentations for the global scope can only be directly nested in external modules or ambient module declarations.
+      const __FOO__: any;
+    }
+    
+==== react-native.ts (1 errors) ====
+    export {}
+    declare module "react-native" {
+                   ~~~~~~~~~~~~~~
+!!! error TS2664: Invalid module name in augmentation, module 'react-native' cannot be found.
+      const __FOO__: any;
+    }
+    

testdata/tests/cases/compiler/invalidGlobalAugmentation.ts

@@ -0,0 +1,13 @@
+// @noTypesAndSymbols: true
+// @noEmit: true
+
+// @Filename: globals.ts
+declare global {
+  const __FOO__: any;
+}
+
+// @Filename: react-native.ts
+export {}
+declare module "react-native" {
+  const __FOO__: any;
+}