RasterDataset and Samplers don't work with non-square pixels

[calebrob6]

Description

If you use RasterDataset with a raster that has non-square pixels (i.e. where x-resolution is different than y-resolution), then RasterDataset will record the resolution of the entire raster as that of the first dimension (probably y-resolution). This is a problem in at least two places:

• Every __getitem__ call to the RasterDataset will result in a resampling, which may be unexpected, and will definitely be slow
• When using Samplers with a patch size in pixel units the bounding boxes that index into the RasterDataset will be generated assuming a square resolution so what you get back won't match up with what you expect.

Steps to reproduce

Use a RasterDataset with a raster that has non-square pixels.

Version

latest

[adamjstewart]

Which data source did you encounter this with? I know OCO-2 and some scanning modes of Sentinel-1 have this trait, curious what other sensors do this.

[calebrob6]

I think it was WorldView level 1B imagery (for disaster response application).

…

On Wed, Feb 19, 2025, 3:51 PM Adam J. Stewart ***@***.***> wrote: Which data source did you encounter this with? I know OCO-2 and some scanning modes of Sentinel-1 have this trait, curious what other sensors do this. — Reply to this email directly, view it on GitHub <#2594 (comment)> or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIJUTSJ4GPJ6BNIMHOQRZL2QUKGLBFKMF2HI4TJMJ2XIZLTSOBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLLDTOVRGUZLDORPXI6LQMWWES43TOVSUG33NNVSW45FGORXXA2LDOOJIFJDUPFYGLKTSMVYG643JORXXE6NFOZQWY5LFVEZTMOJUGI4DSMZVQKSHI6LQMWSWS43TOVS2K5TBNR2WLKRSHA3DINJYGM3DANVHORZGSZ3HMVZKMY3SMVQXIZI> . You are receiving this email because you authored the thread. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub> .