Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary setting of defaults on xunit.net / nunit / (tunit?) #5096

Open
nohwnd opened this issue Feb 21, 2025 · 0 comments
Open

Remove unnecessary setting of defaults on xunit.net / nunit / (tunit?) #5096

nohwnd opened this issue Feb 21, 2025 · 0 comments
Labels
Area: MTP Belongs to the Microsoft.Testing.Platform core library Area: xUnit External: NUnit

Comments

@nohwnd
Copy link
Member

nohwnd commented Feb 21, 2025

Work linked in #4307 (comment) tied the options to IsTestingPlatform and fixed setting the default values to true, so you no longer need to set them to true if you want default value of true.

Once MSTest 3.9.0 ships we can update the frameworks to the latest MTP and remove / revert the properties that set our default values.

Unless the framework wants to use a different value of course.

e.g. like this for NUnit

https://github.com/nunit/nunit3-vs-adapter/compare/master...nohwnd:revert-additional-customizations?expand=1

@nohwnd nohwnd added this to the MSTest 3.10 / MTP 1.8 milestone Feb 21, 2025
@Evangelink Evangelink added the Area: MTP Belongs to the Microsoft.Testing.Platform core library label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: MTP Belongs to the Microsoft.Testing.Platform core library Area: xUnit External: NUnit
Projects
None yet
Development

No branches or pull requests

2 participants