Inconsistent dump file name between crash dump and hang dump

[Youssef1313]

testfx/src/Platform/Microsoft.Testing.Extensions.CrashDump/CrashDumpEnvironmentVariableProvider.cs

Line 117 in 13b5833

: Path.Combine(_configuration.GetTestResultDirectory(), $"{Path.GetFileName(_testApplicationModuleInfo.GetCurrentTestApplicationFullPath())}_%p_crash.dmp");

testfx/src/Platform/Microsoft.Testing.Extensions.HangDump/HangDumpProcessLifetimeHandler.cs

Line 88 in 13b5833

_dumpFileNamePattern = $"{Path.GetFileNameWithoutExtension(testApplicationModuleInfo.GetCurrentTestApplicationFullPath())}_%p_hang.dmp";

One is using Path.GetFileName while the other is using Path.GetFileNameWithoutExtension

[Evangelink]

Let's refactor in a helper class that we will share between the 2 so we are sure a fix is fixing both

[Youssef1313]

@Evangelink It's technically breaking to change the name I think. Maybe a script out there is relying on a file name being in a specific form.

[Evangelink]

Moving to 3.9, this could be seen as a breaking change but this is actually a bug in the first place.