Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making NopFilter public #2787

Open
thomhurst opened this issue May 1, 2024 · 1 comment
Open

Consider making NopFilter public #2787

thomhurst opened this issue May 1, 2024 · 1 comment
Labels
Area: Testing Platform Belongs to the Microsoft.Testing.Platform core library Early experimental feature adopter

Comments

@thomhurst
Copy link
Contributor

Currently NopFilter is internal. However it's the default filter being passed in if doing a basic dotnet run on your test suite.

If we switch on the Type of an ITestExecutionFilter, we're unable to see the NopFilter.

I think it should be public so we can see it when checking the type of filter we've been passed.

@MarcoRossignoli
Copy link
Contributor

MarcoRossignoli commented May 1, 2024

like explained in the guide the filter is in experimental internal mode https://github.com/microsoft/testfx/blob/main/docs/testingplatform/irequest.md#discovertestexecutionrequest but I'd like to find a way to let you use it and feedback us and help to shape it

linked to #2462

cc: @Evangelink

@MarcoRossignoli MarcoRossignoli added Early experimental feature adopter Area: Testing Platform Belongs to the Microsoft.Testing.Platform core library and removed Needs: Triage 🔍 labels May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Testing Platform Belongs to the Microsoft.Testing.Platform core library Early experimental feature adopter
Projects
None yet
Development

No branches or pull requests

2 participants