New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSTEST0016 and base test class #2683
Comments
Hi @avivanoff, As usual thank you for testing our analyzers and for your continuous feedback to improve MSTest :) Assuming you don't have test methods in Side note not related to MSTEST0016 but |
Just to be sure. Does it mean that when you process classes marked with TestClassAttribute you include the whole hierarchy? Will DeploymentItemAttribute on TestBase be processed as well? |
Removal of |
As far as I can see yes, we consider all base types methods.
From the simple test I did this is working.
Let me discuss with the team but I think this is a false positive. |
@Evangelink, any updates? |
Hey @avivanoff, sorry for the missing updates here. We had a few team chat and we haven't yet decided the direction we want to take that's why I postponed the fix for the v3.5 that is happening this sprint. |
We have the following structure in some of our test projects:
After upgrading to 3.3.1 we started getting the error:
error MSTEST0016: Test class 'TestBase' should have at least one test method or be 'static' with method(s) marked by '[AssemblyInitialization]' and/or '[AssemblyCleanup]'
Should MSTEST0016 be checking for this pattern and not trigger the warning/error, or is there a better approach?
The text was updated successfully, but these errors were encountered: