Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.NET: Bug: Microsoft.SemanticKernel.Agents.Abstractions depends on Microsoft.SemanticKernel.Core #10571

Closed
markwallace-microsoft opened this issue Feb 17, 2025 · 1 comment · Fixed by #10574
Closed

.NET: Bug: Microsoft.SemanticKernel.Agents.Abstractions depends on Microsoft.SemanticKernel.Core #10571

markwallace-microsoft opened this issue Feb 17, 2025 · 1 comment · Fixed by #10574
Assignees
@markwallace-microsoft
Labels
agents bug Something isn't working feature_graduation Applied to all feature graduation issues .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)

Comments

@markwallace-microsoft
Copy link
Member

Describe the bug
It should just depend on Microsoft.SemanticKernel.Abstractions and any functionality that requires Microsoft.SemanticKernel.Core should move to the core agents package.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Platform

  • Language: [e.g. C#, Python]
  • Source: [e.g. NuGet package version 0.1.0, pip package version 0.1.0, main branch of repository]
  • AI model: [e.g. OpenAI:GPT-4o-mini(2024-07-18)]
  • IDE: [e.g. Visual Studio, VS Code]
  • OS: [e.g. Windows, Mac]

Additional context
Add any other context about the problem here.
@markwallace-microsoft markwallace-microsoft added bug Something isn't working .NET Issue or Pull requests regarding .NET code python Pull requests for the Python Semantic Kernel triage labels Feb 17, 2025
@github-actions github-actions bot changed the title Bug: Microsoft.SemanticKernel.Agents.Abstractions depends on Microsoft.SemanticKernel.Core .Net: Bug: Microsoft.SemanticKernel.Agents.Abstractions depends on Microsoft.SemanticKernel.Core Feb 17, 2025
@github-actions github-actions bot changed the title .Net: Bug: Microsoft.SemanticKernel.Agents.Abstractions depends on Microsoft.SemanticKernel.Core Python: Bug: Microsoft.SemanticKernel.Agents.Abstractions depends on Microsoft.SemanticKernel.Core Feb 17, 2025
@markwallace-microsoft markwallace-microsoft moved this to Sprint: In Progress in Semantic Kernel Feb 17, 2025
Merged
4 tasks
@markwallace-microsoft markwallace-microsoft removed the python Pull requests for the Python Semantic Kernel label Feb 17, 2025
@markwallace-microsoft markwallace-microsoft changed the title Python: Bug: Microsoft.SemanticKernel.Agents.Abstractions depends on Microsoft.SemanticKernel.Core .NET: Bug: Microsoft.SemanticKernel.Agents.Abstractions depends on Microsoft.SemanticKernel.Core Feb 17, 2025
@markwallace-microsoft markwallace-microsoft moved this from Sprint: In Progress to Sprint: In Review in Semantic Kernel Feb 17, 2025
@evchaki evchaki added the sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) label Feb 18, 2025
@crickman
Copy link
Contributor

I do wonder if there is a defined benefit to restricting this alignment. That is: what benefit is being realized by limiting the dependency to Microsoft.SemanticKernel.Abstractions and not Microsoft.SemanticKernel.Core?

I agree that the dependency footprint should be as minimal as possible.

@crickman crickman added agents feature_graduation Applied to all feature graduation issues bug Something isn't working and removed bug Something isn't working labels Feb 19, 2025
github-merge-queue bot pushed a commit that referenced this issue Feb 20, 2025
@markwallace-microsoft
.Net: Change Agents.Abstractions to depend on SemanticKernel.Abstract…
5c7e759 
…ions instead of SemanticKernel.Core (#10574)

### Motivation and Context

Closes #10571 

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
@crickman crickman moved this from Sprint: In Review to Sprint: Done in Semantic Kernel Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markwallace-microsoft markwallace-microsoft

Labels
agents bug Something isn't working feature_graduation Applied to all feature graduation issues .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Projects
Semantic Kernel
Status: Sprint: Done
Milestone
No milestone
3 participants
@evchaki @crickman @markwallace-microsoft