Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port dotnet feature: .Net: Add prompt execution settings to AutoFunctionInvocationContext #10572

Closed
github-actions bot opened this issue Feb 17, 2025 · 0 comments · Fixed by #10588
Closed

Port dotnet feature: .Net: Add prompt execution settings to AutoFunctionInvocationContext #10572

github-actions bot opened this issue Feb 17, 2025 · 0 comments · Fixed by #10588
Labels
python Pull requests for the Python Semantic Kernel

Comments

@github-actions
Copy link

Original issue

#10551

Description

Motivation, Context and Description

Today, the prompt execution settings supplied to the chat completion service are not available in . This PR adds the new and assigns it to the settings with which the chat completion service was invoked.

Closes: #10475
@github-actions github-actions bot added the python Pull requests for the Python Semantic Kernel label Feb 17, 2025
@eavanvalkenburg eavanvalkenburg mentioned this issue Feb 18, 2025
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Feb 19, 2025
@eavanvalkenburg @moonbox3
Python: filter improvements (#10588)
374d8f9 
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
Fixes some inconsistency in the filter setup between dotnet and python
Adds a sample for how to use a filter to retry a prompt with a different
model.
Adds a sample for semantic caching

Closes: #10572 #5924 #10595

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

---------

Co-authored-by: Evan Mattson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
python Pull requests for the Python Semantic Kernel
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Python: filter improvements eavanvalkenburg/semantic-kernel
0 participants