Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Change Agents.Abstractions to depend on SemanticKernel.Abstractions instead of SemanticKernel.Core #10574

Conversation

markwallace-microsoft
Copy link
Member

Motivation and Context

Closes #10571

Description

Contribution Checklist

@markwallace-microsoft markwallace-microsoft requested a review from a team as a code owner February 17, 2025 17:14
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel.core labels Feb 17, 2025
@github-actions github-actions bot changed the title Change Agents.Abstractions to depend on SemanticKernel.Abstractions .Net: Change Agents.Abstractions to depend on SemanticKernel.Abstractions Feb 17, 2025
@markwallace-microsoft markwallace-microsoft changed the title .Net: Change Agents.Abstractions to depend on SemanticKernel.Abstractions .Net: Change Agents.Abstractions to depend on SemanticKernel.Abstractions instead of SemanticKernel.Core Feb 17, 2025
@markwallace-microsoft
Copy link
Member Author

Waiting on feedback from @crickman

@crickman crickman added agents feature_graduation Applied to all feature graduation issues labels Feb 19, 2025
Copy link
Contributor

@crickman crickman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like we're still missing the case were an Azure Agent or Assistant was created with a template and the rehydrated from an existing model/definition via retrieval by its identifier.

In that case, would the developer be expected to also provide the full template config?

What would be the behavior when the provided template config doesn't match this existing definition?

@crickman crickman self-requested a review February 20, 2025 16:17
@markwallace-microsoft
Copy link
Member Author

Feels like we're still missing the case were an Azure Agent or Assistant was created with a template and the rehydrated from an existing model/definition via retrieval by its identifier.

In that case, would the developer be expected to also provide the full template config?

What would be the behavior when the provided template config doesn't match this existing definition?

This case needs to be handled as part of the declarative agent framework. My initial thought is that it should be possible to override instructions, provide additional tools, etc for an already deployed agent. Overriding instructions will be useful if the template contains values that are related to the current request.

@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue Feb 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 20, 2025
@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue Feb 20, 2025
Merged via the queue into microsoft:main with commit 5c7e759 Feb 20, 2025
19 checks passed
@markwallace-microsoft markwallace-microsoft deleted the users/markwallace/10571 branch February 20, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agents feature_graduation Applied to all feature graduation issues kernel.core .NET Issue or Pull requests regarding .NET code
Projects
Status: Sprint: Done
Development

Successfully merging this pull request may close these issues.

.NET: Bug: Microsoft.SemanticKernel.Agents.Abstractions depends on Microsoft.SemanticKernel.Core
5 participants