Skip to content

Safari mute button has no focus visible styling and is out of sequence #6207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
microbit-matt-hillsdon opened this issue May 13, 2025 · 2 comments · Fixed by #6237
Closed
Assignees
Labels

Comments

@microbit-matt-hillsdon
Copy link
Contributor

It's the tab stop before the stop button, but that's unexpected based on the layout and focus isn't visible so you feel lost tabbing through.

Image

I'm not sure if the placement when full screen is intended but it makes picking a sequence awkward as it can be before the board, partially over the board or to the right of the board depending on screen width:

Image

@abchatra
Copy link
Collaborator

@microbit-matt-hillsdon I don't understand this issue. Can you elaborate? @riknoll do you have any idea?

@microbit-matt-hillsdon
Copy link
Contributor Author

microbit-matt-hillsdon commented May 13, 2025

Clearer steps:

  1. In Safari, tab until the stop button in the sim is focussed
  2. Shift-tab and notice there's no focus outline anywhere (you can reach this state tabbing forward too, just harder to pin down what's happened that way)
  3. Press enter or query document.activeElement and realise it was the Safari mute button

The button should have a clear focus indicator (e.g. outline) and the tab position should be in a logical sequence with respect to other components on the board.

We sorted the tab order for other sim components in #6113 but not this Safari specific one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants