Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show LEDs on hardware does not match the old behavior #2908

Closed
riknoll opened this issue Apr 24, 2020 · 7 comments
Closed

Show LEDs on hardware does not match the old behavior #2908

riknoll opened this issue Apr 24, 2020 · 7 comments
Assignees
Labels
bug device For bugs that repro on the device next-release

Comments

@riknoll
Copy link
Member

riknoll commented Apr 24, 2020

In the latest beta, calling showLeds clears the screen after the interval has passed. The old behavior was to leave the last displayed image up on the screen.

Here's a MakeCode program that demonstrates it:

input.onButtonPressed(Button.A, function() {
    basic.showLeds(`
    . . . . .
    . # . # .
    . . . . .
    # . . . #
    . # # # .
    `)
})

This only shows up on the hardware, not in the sim

@riknoll riknoll added bug device For bugs that repro on the device labels Apr 24, 2020
@riknoll
Copy link
Member Author

riknoll commented Apr 24, 2020

@finneyj FYI

@pelikhan pelikhan self-assigned this Apr 24, 2020
@pelikhan
Copy link
Member

I'll investigate to see if this was my change.

@pelikhan
Copy link
Member

Regression in microbit-dal lancaster-university/microbit-dal#463

@finneyj
Copy link

finneyj commented Apr 24, 2020

arrgh. Though I'd nailed these - sorry guys.

To clarify, for consistency in MakeCode, all print() methods (be it char, string or image) should not clear the screen for length==1 operations?

@finneyj
Copy link

finneyj commented Apr 24, 2020

clarification - even when a duration is explicitly set?

@finneyj
Copy link

finneyj commented Apr 24, 2020

Apologies. Fixed in microbit-dal v2.2.0-rc5

@pelikhan
Copy link
Member

No clearing when it does not scroll.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug device For bugs that repro on the device next-release
Projects
None yet
Development

No branches or pull requests

3 participants