Skip to content

[Bug]: Drop target stays visible when accidentally dragging and dropping text into trace viewer #38361

@cpAdm

Description

@cpAdm

Version

1.57.0

Steps to reproduce

  1. Open trace viewer
  2. Select text
  3. Drag and drop this text into the trace viewer

Expected behavior

To not see drop target

Actual behavior

Drop target remains active after dropping the text

Image

Additional context

dragOver is never set to false when processTraceFiles is called with empty array of files
https://github.com/cpAdm/playwright/blob/4c65ab3df5f16c3ba8c41303aa302859839d6552/packages/trace-viewer/src/ui/workbenchLoader.tsx#L87-L90

Environment

System:
    OS: Windows 10 10.0.19045
    CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
    Memory: 1.93 GB / 15.83 GB
  Binaries:
    Node: 24.11.0 
    npm: 11.6.1
  npmPackages:
    @playwright/test: ^1.56.0 => 1.57.0

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions