Skip to content

Commit 797ee5a

Browse files
Copilotdanmarshall
andcommitted
Addressing PR comments
Co-authored-by: danmarshall <[email protected]>
1 parent e9489e5 commit 797ee5a

File tree

3 files changed

+2
-20
lines changed

3 files changed

+2
-20
lines changed

packages/maker.js/src/core/dxf.ts

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,3 @@
1-
// Minimal DxfParser type declarations for DXF export functionality
2-
// Full types provided by dxf-parser-typings package when available
3-
declare namespace DxfParser {
4-
interface Vertex { x: number; y: number; z?: number; bulge?: number; }
5-
interface Entity { type?: string; layer?: string; [key: string]: any; }
6-
interface EntityLINE extends Entity { type: 'LINE'; vertices?: Vertex[]; }
7-
interface EntityCIRCLE extends Entity { type: 'CIRCLE'; center?: Vertex; radius?: number; }
8-
interface EntityARC extends Entity { type: 'ARC'; center?: Vertex; radius?: number; startAngle?: number; endAngle?: number; }
9-
interface EntityVERTEX extends Entity { x: number; y: number; z?: number; bulge?: number; }
10-
interface EntityPOLYLINE extends Entity { type: 'POLYLINE'; vertices?: EntityVERTEX[]; }
11-
interface EntityTEXT extends Entity { type: 'TEXT'; startPoint?: Vertex; text?: string; textHeight?: number; }
12-
interface Layer { name?: string; colorIndex?: number; color?: number; }
13-
interface LineType { name?: string; description?: string; pattern?: number[]; patternLength?: number; }
14-
interface Table { handle?: string; }
15-
interface TableLTYPE extends Table { lineTypes?: { [name: string]: LineType }; }
16-
interface TableLAYER extends Table { layers?: { [name: string]: Layer }; }
17-
type TableNames = 'layer' | 'lineType' | 'viewPort';
18-
interface DXFDocument { entities?: Entity[]; header?: any; tables?: { [name: string]: Table }; }
19-
}
20-
211
namespace MakerJs.exporter {
222

233
export function toDXF(modelToExport: IModel, options?: IDXFRenderOptions): string;

packages/maker.js/target/tsconfig.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
"lib": ["dom", "es2015"],
66
"sourceMap": false,
77
"skipLibCheck": true,
8+
"typeRoots": ["../../../node_modules/@types"],
89
"types": [
910
"@danmarshall/jscad-typings",
1011
"bezier-js",

packages/maker.js/tsconfig.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
"outDir": "debug/",
55
"sourceMap": true,
66
"skipLibCheck": true,
7+
"typeRoots": ["../../node_modules/@types"],
78
"types": [
89
"@danmarshall/jscad-typings",
910
"bezier-js",

0 commit comments

Comments
 (0)