Skip to content

Commit 336aaa5

Browse files
committed
PHP integration tests: generate client consistently in 'Client' dir matching the namespace
1 parent 7f852c1 commit 336aaa5

2 files changed

Lines changed: 7 additions & 4 deletions

File tree

it/get-additional-arguments.ps1

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,10 @@ elseif ($language -eq "ruby") {
3636
$command = " --output `"./it/$language/lib/integration_test/client`" --namespace-name `"integration_test.client`""
3737
}
3838
elseif ($language -eq "php") {
39-
$command = " --output `"./it/$language/src/client`" --namespace-name `"integration.test.client`""
39+
#Destination Path: use upper case "Client" here, as the test imports the namespace "Integration\Test\Client\...",
40+
#and as composer.json defines the autoload/psr-4 path "Integration\Test\", PHP would search the sub-namespaces in subdirs with the same casing.
41+
#That's might be relevant when running on Linux, though it did not cause problems.
42+
$command = " --output `"./it/$language/src/Client`" --namespace-name `"integration.test.client`""
4043
}
4144
elseif ($language -eq "python") {
4245
$command = " --output `"./it/$language/integration_test/client`" --namespace-name `"integration_test.client`""

it/php/.gitignore

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
#generated api code if integration test is run locally
2-
src/client/
2+
src/Client/
33

44
vendor
55
composer.lock
66

77
#generated api client is copied from "src" to the mock server folder. Ignore it there, too.
8-
/basic/src/client/
9-
/defaultvalues/src/client/
8+
/basic/src/Client/
9+
/defaultvalues/src/Client/

0 commit comments

Comments
 (0)