Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align implementations and signatures of public methods handling primitives. #408

Open
andrueastman opened this issue Nov 13, 2024 · 0 comments
Labels
type:breaking-change An issue that will result in dependent client projects failing. type:bug A broken experience

Comments

@andrueastman
Copy link
Member

The implementations for send_primitive and send_collection_of_primitive_async is inconsistent.

If you take a look at the implementation for send_primitive, you'll see that it expects string literals.

However, the implementation for send_collection_of_primitive_async expects types, so making them consistent would be the breaking change.

At the next major version we should change the implementation of send_primitive to take a type parameter instead rather than string literals. This will enable better type validation and more accurate static analysis of parameter passed into the function

@andrueastman andrueastman added the enhancement New feature or request label Nov 13, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Kiota Nov 13, 2024
@andrueastman andrueastman added the type:breaking-change An issue that will result in dependent client projects failing. label Nov 13, 2024
@andrueastman andrueastman moved this from Needs Triage 🔍 to Todo 📃 in Kiota Nov 13, 2024
@andrueastman andrueastman added bug Something isn't working type:bug A broken experience and removed enhancement New feature or request bug Something isn't working labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:breaking-change An issue that will result in dependent client projects failing. type:bug A broken experience
Projects
Status: Todo 📃
Development

No branches or pull requests

1 participant