Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http - align OTEL http attributes with latest standard #1540

Open
baywet opened this issue Aug 27, 2024 · 2 comments
Open

http - align OTEL http attributes with latest standard #1540

baywet opened this issue Aug 27, 2024 · 2 comments
Labels
bug Something isn't working help wanted Standard GitHub label type:bug A broken experience

Comments

@baywet
Copy link
Member

baywet commented Aug 27, 2024

to maintain compatibility with external tooling we should make sure our attribute respect the latest (stable) semantic conventions. When we initially implemented things, the spec was still in draft. The following attributes need to be renamed in the middleware handlers and in the request adapter:
htttp.status_code => http.response.status_code
http.response_content_length => http.response.body.size
http.request_content_length => http.request.body.size
http.flavor => network.protocol.name
http.response_content_type => http.response.header.content-type
http.request_content_type => http.request.header.content-type
http.method => http.request.method
http.host => url.scheme
http.scheme => server.address
http.uri => url.full
http.uri_template => url.uri_template

link to the spec for more information https://opentelemetry.io/docs/specs/semconv/attributes-registry/http/
related microsoftgraph/msgraph-sdk-design#108

@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Kiota Aug 27, 2024
@baywet baywet moved this from Needs Triage 🔍 to Todo 📃 in Kiota Aug 27, 2024
@baywet baywet added bug Something isn't working type:bug A broken experience help wanted Standard GitHub label labels Aug 27, 2024
@Strazz1337
Copy link

I wonder what the preferred way is for implementing the updated OTEL attributes:

@baywet
Copy link
Member Author

baywet commented Oct 14, 2024

Hi @Strazz1337
Thanks for all the pull requests and for inquiring on this one.
We'd probably go the route of expanding the constants, here is some more context on why #1232
Let us know if you have any additional comments or questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Standard GitHub label type:bug A broken experience
Projects
Status: Todo 📃
Development

No branches or pull requests

2 participants