Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components not honoring the theme? #3678

Open
2 of 6 tasks
riosn-n opened this issue Jul 10, 2024 · 3 comments
Open
2 of 6 tasks

Components not honoring the theme? #3678

riosn-n opened this issue Jul 10, 2024 · 3 comments

Comments

@riosn-n
Copy link
Member

riosn-n commented Jul 10, 2024

Willing to submit a PR to fix?

  • I am willing to submit a PR to fix

Requested priority

High

Products/applications affected

Power Apps

Package version(s)

latest

OS version(s)

No response

Platform

  • iOS
  • macOS
  • win32
  • windows
  • android

Xcode version

No response

Please provide a reproduction of the bug

https://snack.expo.dev/@nerios/furn-theming?platform=android

Actual behavior

Components don't change their looks based on the theme.

Expected behavior

Components change their looks based on the theme.

@rurikoaraki
Copy link
Collaborator

Hi, the snack doesn't seem to work, but you can get more information about how to use the theme with a specific platform here: https://github.com/microsoft/fluentui-react-native/blob/main/docs/pages/Theming/DefaultThemes.md#android

In general you'll want to use createAndroidTheme/createAppleTheme for theming your components on particular platforms. These themes will respond to OS settings.

@riosn-n
Copy link
Member Author

riosn-n commented Jul 10, 2024

This screenshot shows what I get when I switch to createAndroidTheme in my POC. The appearance option seems to have no effect.

image

@rurikoaraki
Copy link
Collaborator

HC is not supported on Android. It will fall back to light.

Unfortunately, the team is currently tied up in other priorities so we don't have bandwidth to debug and diagnose the issue on our own. If you'd be willing to help debug the issue, I can guide you to a workaround or fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants