Skip to content
This repository was archived by the owner on Feb 15, 2022. It is now read-only.

Remove dependencies of unmaintained forks: #317

Open
evanlouie opened this issue Nov 2, 2020 · 1 comment
Open

Remove dependencies of unmaintained forks: #317

evanlouie opened this issue Nov 2, 2020 · 1 comment
Assignees

Comments

@evanlouie
Copy link
Contributor

  • github.com/timfpark/conjungo
    • github.com/imdario/mergo should work
  • github.com/timfpark/yaml
    • gopkg.in/yaml.v3 should work
  • Write tests based on existing packages and ensure still pass after swap out
@andrewDoing andrewDoing self-assigned this Nov 3, 2020
@andrewDoing
Copy link
Collaborator

andrewDoing commented Nov 3, 2020

After some investigation, neither of the proposed libraries can replace the same functionality without modification.

mergo: The mergo.Merge function can't replace conjungo.Merge because the current config gets overwritten in case of a conflict.
Edit: The use of a transform function that avoids overwriting zero-value booleans could be developed.

gopkg.in/yaml.v2: The defaultMapType is hardcoded and cannot be overwritten, which appears to be the purpose of forking the repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants