Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workarounds for verifier loop limitation once fixed #1993

Open
dthaler opened this issue Feb 1, 2023 · 0 comments
Open

Remove workarounds for verifier loop limitation once fixed #1993

dthaler opened this issue Feb 1, 2023 · 0 comments
Assignees
Labels
blocked Blocked on another issue that must be done first cleanup Affects API usability or code maintainability but not correctness or applicability triaged Discussed in a triage meeting
Milestone

Comments

@dthaler
Copy link
Collaborator

dthaler commented Feb 1, 2023

Describe the bug

vbpf/ebpf-verifier#441 prevents verifying programs with loops.
PR #1991 puts a workaround in place in 3 sample programs.
This issue is to track removing the workaround once the verifier limitation is addressed.

Sample programs affected:
bindmonitor.c
bindmonitor_tailcall.c
map.c

OS information

No response

Steps taken to reproduce bug

Try to verify sample programs with loops.

Expected behavior

Samples pass verification without the workaround in place.

Actual outcome

Samples fail verification without the workaround in place.

Additional details

No response

@dthaler dthaler added bug Something isn't working cleanup Affects API usability or code maintainability but not correctness or applicability blocked Blocked on another issue that must be done first and removed bug Something isn't working labels Feb 1, 2023
@dahavey dahavey added the triaged Discussed in a triage meeting label Feb 6, 2023
@dahavey dahavey added this to the 2302 milestone Feb 6, 2023
@dthaler dthaler modified the milestones: 2302, 2303 Feb 27, 2023
@dahavey dahavey modified the milestones: 2303, 2304 Mar 20, 2023
@dthaler dthaler modified the milestones: 2304, 2305 Apr 24, 2023
@dthaler dthaler modified the milestones: 2305, 2306 Jun 1, 2023
@dthaler dthaler modified the milestones: 2306, 2307 Jun 29, 2023
@dthaler dthaler modified the milestones: 2307, 2308 Jul 24, 2023
@dthaler dthaler modified the milestones: 2308, 2309 Aug 28, 2023
@dthaler dthaler modified the milestones: 2309, 2310 Sep 18, 2023
@shankarseal shankarseal modified the milestones: 2310, 2311 Oct 23, 2023
@shankarseal shankarseal modified the milestones: 2311, 2401 Nov 28, 2023
@dthaler dthaler removed the blocked Blocked on another issue that must be done first label Jan 2, 2024
@dthaler dthaler removed this from the 2401 milestone Jan 15, 2024
@dthaler dthaler added this to the 2402 milestone Jan 15, 2024
@shankarseal shankarseal modified the milestones: 2402, 2403 Feb 28, 2024
@dthaler dthaler added the blocked Blocked on another issue that must be done first label Mar 18, 2024
@dahavey dahavey modified the milestones: 2403, 2404 Mar 27, 2024
@dthaler dthaler modified the milestones: 2404, 2405 Apr 15, 2024
@dthaler dthaler modified the milestones: 2405, 2406 May 7, 2024
@shankarseal shankarseal modified the milestones: 2406, 2407 Jun 26, 2024
@dthaler dthaler modified the milestones: 2407, 2408 Jul 22, 2024
@dthaler dthaler modified the milestones: 2408, 2409 Aug 19, 2024
@dthaler dthaler modified the milestones: 2409, 2410 Sep 9, 2024
@shankarseal shankarseal modified the milestones: 2410, 2411 Sep 30, 2024
@shankarseal shankarseal modified the milestones: 2411, 2501 Nov 2, 2024
@dthaler dthaler changed the title Remove workarounds for verifier limitation once fixed Remove workarounds for verifier loop limitation once fixed Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked on another issue that must be done first cleanup Affects API usability or code maintainability but not correctness or applicability triaged Discussed in a triage meeting
Projects
None yet
Development

No branches or pull requests

3 participants