Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive controls become non-interactive after adding it back #1470

Closed
HO-COOH opened this issue Mar 1, 2024 · 0 comments · Fixed by #1550
Closed

Interactive controls become non-interactive after adding it back #1470

HO-COOH opened this issue Mar 1, 2024 · 0 comments · Fixed by #1550
Assignees
Labels
bug Something isn't working

Comments

@HO-COOH
Copy link
Contributor

HO-COOH commented Mar 1, 2024

Which version of the app?

WinUI 3 Gallery

Description

  1. Go to "TitleBar" page
  2. Click Add interactive control to titlebar
  3. Click Remove interactive control to titlebar
  4. Click Add interactive control to titlebar again
    Now the textbox in the titlebar is no longer clickable.

Screenshots

No response

Windows version

Windows 11 22H2 (22621)

Additional context

No response

@HO-COOH HO-COOH added bug Something isn't working needs-triage labels Mar 1, 2024
@karkarl karkarl self-assigned this Apr 11, 2024
karkarl pushed a commit that referenced this issue Jun 11, 2024
…econd time (#1550)

<!--- Provide a general summary of your changes in the Title above -->

## Description
- `AppTitleBarTextBox` 's `Width` is not set, so `Width +=1 ` does
nothing
- The `SizeChanged` event handler is called **once**, because of
`Visibility` changed, and it was put in a `StackPanel` that's vertically
constrained, so the size change will occur once, not because `Width +=
1`. Consecutive adding it to the title bar no longer triggers the event
handler, therefore the issue
- And `Width += 1` is a dirty hack anyway, does not need that.

## Motivation and Context
Close #1470

## How Has This Been Tested?
Manual.

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants