Make <string_view> slimmer by default
#4633
Open
+1,828
−1,791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new header `<__msvc_string_view.hpp>` provides `char_traits` and `basic_string_view` and related utilities. `<string_view>` shouldn't provide other utilities in `<xstring>`. `<ranges>` seemingly still need to include `<xmemory>` in C++23 due to `elements_of` whose default template argument depends on `allocator`. Escape hatch `_LEGACY_CODE_ASSUMES_STRING_VIEW_INCLUDES_XSTRING` is added to restore legacy inclusion. MSVC-internal changes are needed due to the new internal header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new header
<__msvc_string_view.hpp>provideschar_traitsandbasic_string_viewand related utilities.<string_view>shouldn't provide other utilities in<xstring>. Fixes #4625.<ranges>seemingly still need to include<xmemory>in C++23 due toelements_ofwhose default template argument depends onallocator(see #4620).Escape hatch
_LEGACY_CODE_ASSUMES_STRING_VIEW_INCLUDES_XSTRINGis provided to restore legacy inclusion.MSVC-internal changes are needed due to the new internal header.