Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new IR Node to represent TypeLiterals and NamedTypes #2648

Open
adithyaselv opened this issue Sep 23, 2024 · 1 comment
Open

Create a new IR Node to represent TypeLiterals and NamedTypes #2648

adithyaselv opened this issue Sep 23, 2024 · 1 comment
Assignees

Comments

@adithyaselv
Copy link
Contributor

adithyaselv commented Sep 23, 2024

Today we serialize the TypeLiterals and NamedTypes to strings and then deserialize it into DType in the runtime implementation of a function. Having a separate IR node for this would result in cleaner implementation and would avoid unnecessary Serialization and DeSerialization

@adithyaselv adithyaselv self-assigned this Sep 23, 2024
@MikeStall
Copy link
Contributor

+1.
There's a related issue of how we pass the type into the function at runtime. Ideally, this would also be a dtype (and not a string to deserialize).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants