Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'dotnet new' templates for NoTargets and Traversal #529

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

MattKotsenas
Copy link

@MattKotsenas MattKotsenas commented Jan 14, 2024

Fixes #472

Add two new projects: Microsoft.Build.NoTargets.Templates and Microsoft.Build.Traversal.Templates that each publish a NuGet package that can be installed / used via dotnet new.

I wasn't quite sure how best to structure the project, so feedback is appreciated. Some things to consider:

  • The template projects currently live under their respective "feature" folders. It's also common to create a top-level "Templates" folder like this, however that breaks the package-per-feature pattern currently used in the repo.
    • Additionally, currently the templates folder is a child of the main project in the source tree, but they're more conceptually siblings. If there's a different arrangement that makes more sense to people let me know.
  • Currently the version for the template packages match the version of the SDK package. I think that makes sense, but if they should be versioned independently I can make that change as well.
  • The NoTargets template uses the .msbuildproj extension. If we should use .proj, or if there's a better extension to use please let me know.
  • I added several comments to help new users, but there may be so much that it's annoying for experienced users. Editing feedback welcome.
  • In order to keep the NoTargets template consistent with the README, I changed the TargetFrameworkVersion in the README from net462 to netstandard2.0, since that's compatible with both .NET Framework and .NET, and still supported (basically) everywhere.

@MattKotsenas
Copy link
Author

Friendly ping here. I fully expect this review to take a couple of rounds to get the directory layout the way maintainers want, so any help / guidance is very appreciated. Thanks!

@jeffkl
Copy link
Contributor

jeffkl commented Feb 27, 2024

@AndyGerlicher has assumed ownership of this repo

@AndyGerlicher
Copy link
Member

Just FYI discussing this internally with the MSBuild team. I want to make sure this aligns with their vision before we make this change. Sorry for the delay!

@MattKotsenas
Copy link
Author

Hi there! Friendly ping here. Any updates, or concerns / issues I can help address? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: dotnet templates package for Traversal and NoTargets projects
3 participants